chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

index ab938b2d43a3bce07937624f4599a315a7156f56..8b8423d76aaaae8437b1da847ee0724d56c9b9da 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

@@ -198,8 +198,8 @@ cvox.ApiImplementation.stop = function() {

* @param {string} earcon An earcon name.

cvox.ApiImplementation.playEarcon = function(earcon) {

- if (cvox.ChromeVox.isActive) {

- cvox.ChromeVox.earcons.playEarconByName(earcon);

+ if (cvox.ChromeVox.isActive && cvox.Earcon[earcon]) {

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon[earcon]);

}

};