chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js ('k') | chrome/browser/resources/chromeos/chromevox/host/interface/abstract_earcons.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js b/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js

index 22285e6f9ebf6a74967545d89b96701615648a45..500da1a1e4825b75a2782ed54ac0ad4690b922e8 100644

--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js

+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js

@@ -54,13 +54,13 @@ cvox.EarconsBackground.prototype.playEarcon = function(earcon) {

return;

}

if (window['console']) {

- window['console']['log']('Earcon ' + this.getEarconName(earcon));

+ window['console']['log']('Earcon ' + earcon);

}

this.currentAudio = this.audioMap[earcon];

if (!this.currentAudio) {

this.currentAudio = new Audio(chrome.extension.getURL(this.getBaseUrl() +

- this.getEarconFilename(earcon)));

+ earcon + '.ogg'));

this.audioMap[earcon] = this.currentAudio;

}

try {