Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5557)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/earcon_util.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Patch Set: Fixed test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/common/earcon_util.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/earcon_util.js b/chrome/browser/resources/chromeos/chromevox/common/earcon_util.js
index c938d9b7d7c861356bd46a1fb132bbe693a68202..51679ab007e8448a2c4da4d5ba65ecb01b87e006 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/earcon_util.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/earcon_util.js
@@ -16,7 +16,7 @@ goog.require('cvox.DomUtil');
* Returns the id of an earcon to play along with the description for a node.
*
* @param {Node} node The node to get the earcon for.
- * @return {number?} The earcon id, or null if none applies.
+ * @return {cvox.Earcon?} The earcon id, or null if none applies.
*/
cvox.EarconUtil.getEarcon = function(node) {
var earcon = cvox.AriaUtil.getEarcon(node);
@@ -26,40 +26,40 @@ cvox.EarconUtil.getEarcon = function(node) {
switch (node.tagName) {
case 'BUTTON':
- return cvox.AbstractEarcons.BUTTON;
+ return cvox.Earcon.BUTTON;
case 'A':
if (node.hasAttribute('href')) {
- return cvox.AbstractEarcons.LINK;
+ return cvox.Earcon.LINK;
}
break;
case 'IMG':
if (cvox.DomUtil.hasLongDesc(node)) {
- return cvox.AbstractEarcons.LONG_DESC;
+ return cvox.Earcon.LONG_DESC;
}
break;
case 'LI':
- return cvox.AbstractEarcons.LIST_ITEM;
+ return cvox.Earcon.LIST_ITEM;
case 'SELECT':
- return cvox.AbstractEarcons.LISTBOX;
+ return cvox.Earcon.LISTBOX;
case 'TEXTAREA':
- return cvox.AbstractEarcons.EDITABLE_TEXT;
+ return cvox.Earcon.EDITABLE_TEXT;
case 'INPUT':
switch (node.type) {
case 'button':
case 'submit':
case 'reset':
- return cvox.AbstractEarcons.BUTTON;
+ return cvox.Earcon.BUTTON;
case 'checkbox':
case 'radio':
if (node.checked) {
- return cvox.AbstractEarcons.CHECK_ON;
+ return cvox.Earcon.CHECK_ON;
} else {
- return cvox.AbstractEarcons.CHECK_OFF;
+ return cvox.Earcon.CHECK_OFF;
}
default:
if (cvox.DomUtil.isInputTypeText(node)) {
// 'text', 'password', etc.
- return cvox.AbstractEarcons.EDITABLE_TEXT;
+ return cvox.Earcon.EDITABLE_TEXT;
}
}
}

Powered by Google App Engine
This is Rietveld 408576698