chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

index b5638968f71d213027f943543caac96f98dafe0d..d4c228cb8acb10af62f0b51efeaf4ee248b22063 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

@@ -1104,9 +1104,9 @@ cvox.ChromeVoxEventWatcher.handleControlChanged = function(control) {

announceChange = true;

// Play earcons for checkboxes and radio buttons

if (control.checked) {

- cvox.ChromeVox.earcons.playEarcon(cvox.AbstractEarcons.CHECK_ON);

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.CHECK_ON);

} else {

- cvox.ChromeVox.earcons.playEarcon(cvox.AbstractEarcons.CHECK_OFF);

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.CHECK_OFF);

}