chrome/browser/resources/chromeos/chromevox/common/nav_description.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/nav_description.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/earcon_util.js ('k') | chrome/browser/resources/chromeos/chromevox/common/nav_math_description.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/nav_description.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/nav_description.js b/chrome/browser/resources/chromeos/chromevox/common/nav_description.js

index e143ca17d1ddc4ba9741bd260e8e7ed4fa9eb115..a158b5746c88b2fcc90478ca022edc60528e24da 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/nav_description.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/nav_description.js

@@ -23,7 +23,7 @@ goog.require('cvox.QueueMode');

* text: (string),

* userValue: (undefined|string),

* annotation: (undefined|string),

- * earcons: (undefined|Array<number>),

+ * earcons: (undefined|Array<cvox.Earcon>),

* personality: (undefined|Object),

* hint: (undefined|string),

category: (undefined|string)}} kwargs The arguments for this

@@ -81,8 +81,8 @@ cvox.NavDescription.prototype.toString = function() {

/**

* Modifies the earcon to play along with the spoken description of the object.

- * @param {number} earconId An earcon id to be pushed on to the list of earcon

- * ids to play along with the spoken description of this object.

+ * @param {cvox.Earcon} earconId An earcon id to be pushed on to the list of

+ * earcon ids to play along with the spoken description of this object.

cvox.NavDescription.prototype.pushEarcon = function(earconId) {

this.earcons.push(earconId);