chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js

diff --git a/chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js b/chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js

index ac6a42924b9f5af4c7dd4cce1c44e0e6d2e6ca72..9c8175a6627750581e88b4991ffc31133897e1ab 100644

--- a/chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js

+++ b/chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js

@@ -238,7 +238,7 @@ cvox.Search.keyhandler = function(evt) {

cvox.Search.index = cvox.SearchUtil.subOneWrap(cvox.Search.index,

cvox.Search.results.length);

if (cvox.Search.index === cvox.Search.results.length - 1) {

- cvox.ChromeVox.earcons.playEarconByName('WRAP');

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.WRAP);

}

cvox.Search.syncToIndex();

break;

@@ -247,7 +247,7 @@ cvox.Search.keyhandler = function(evt) {

cvox.Search.index = cvox.SearchUtil.addOneWrap(cvox.Search.index,

cvox.Search.results.length);

if (cvox.Search.index === 0) {

- cvox.ChromeVox.earcons.playEarconByName('WRAP');

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.WRAP);

}

cvox.Search.syncToIndex();

break;