Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2418)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Patch Set: Fixed test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
index 8c48e1dc933d859f1c5abd958ca9322df7a60bd4..6d40b881db6eb5c335a4d8625d145f8a4de6b7b2 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
@@ -62,7 +62,7 @@ cvox.TabsApiHandler.prototype = {
cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
this.braille_.write(
cvox.NavBraille.fromText(this.msg_('chrome_tab_created')));
- this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_OPEN);
+ this.earcons_.playEarcon(cvox.Earcon.OBJECT_OPEN);
},
/**
@@ -73,7 +73,7 @@ cvox.TabsApiHandler.prototype = {
if (!cvox.ChromeVox.isActive) {
return;
}
- this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_CLOSE);
+ this.earcons_.playEarcon(cvox.Earcon.OBJECT_CLOSE);
},
/**
@@ -96,7 +96,7 @@ cvox.TabsApiHandler.prototype = {
cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
this.braille_.write(
cvox.NavBraille.fromText(this.msg_('chrome_tab_selected', [title])));
- this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
+ this.earcons_.playEarcon(cvox.Earcon.OBJECT_SELECT);
}.bind(this));
},
@@ -115,10 +115,10 @@ cvox.TabsApiHandler.prototype = {
}
if (tab.status == 'loading') {
this.lastActiveTabLoaded_ = false;
- this.earcons_.playEarcon(cvox.AbstractEarcons.BUSY_PROGRESS_LOOP);
+ this.earcons_.playEarcon(cvox.Earcon.BUSY_PROGRESS_LOOP);
} else if (!this.lastActiveTabLoaded_) {
this.lastActiveTabLoaded_ = true;
- this.earcons_.playEarcon(cvox.AbstractEarcons.TASK_SUCCESS);
+ this.earcons_.playEarcon(cvox.Earcon.TASK_SUCCESS);
}
}.bind(this));
},
@@ -145,7 +145,7 @@ cvox.TabsApiHandler.prototype = {
cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
this.braille_.write(
cvox.NavBraille.fromText(this.msg_(msgId, [title])));
- this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
+ this.earcons_.playEarcon(cvox.Earcon.OBJECT_SELECT);
}.bind(this));
}.bind(this));
}
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698