chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

index b34641b3dd6ba327e8355af93e0837d046d56731..73acdeacae7dc1518a0cf7196632097e2bdce310 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

@@ -493,7 +493,7 @@ SYNC_TEST_F('OutputE2ETest', 'MessageIdAndEarconValidity', function() {

cvox.ChromeVox.msgs.getMsg(value.msgId + '_brl');

assertFalse(/[A-Z]+/.test(value.msgId));

if (value.earconId)

- assertNotNullNorUndefined(cvox.AbstractEarcons[value.earconId]);

+ assertNotNullNorUndefined(cvox.Earcon[value.earconId]);

}

for (var key in Output.STATE_INFO_) {

var value = Output.STATE_INFO_[key];

@@ -503,7 +503,7 @@ SYNC_TEST_F('OutputE2ETest', 'MessageIdAndEarconValidity', function() {

cvox.ChromeVox.msgs.getMsg(innerValue.msgId + '_brl');

assertFalse(/[A-Z]+/.test(innerValue.msgId));

if (innerValue.earconId)

- assertNotNullNorUndefined(cvox.AbstractEarcons[innerValue.earconId]);

+ assertNotNullNorUndefined(cvox.Earcon[innerValue.earconId]);

}

});