Unify graphics buffer format & usage enums for GpuMemoryBuffer & SurfaceFactoryOzone

Unify graphics buffer enums for GpuMemoryBuffer & SurfaceFactoryOzone

This moves the gfx::GpuMemoryBuffer::BufferFormat to gfx::BufferFormat
and moves gfx::GpuMemoryBuffer:BufferUsage to gfx::BufferUsage, and
removes the ozone versions in favor of a common type. This avoids
unnecessary conversions.

There should be no functional change.

BUG=none
TEST=compile & run for CrOS, compile for all other platforms
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jam (API change)

Committed: https://crrev.com/fcf5fab44b781da53a711476c4d48950ecf764b3
Cr-Commit-Position: refs/heads/master@{#341758}

[spang, 2015-07-31 06:40:14]

spang@chromium.org changed reviewers:
+ reveman@chromium.org

[spang, 2015-07-31 06:40:15]

WDYT about sharing these enums?

[reveman, 2015-07-31 16:36:23]

good idea, lgtm

[spang, 2015-07-31 16:39:18]

spang@chromium.org changed reviewers:
+ danakj@chromium.org, kenrb@chromium.org

[spang, 2015-07-31 16:39:19]

danakj: please review ui/gfx
kenrb: please review ui/gfx/ipc
everything else: TBR

[dshwang, 2015-08-03 12:21:34]

dongseong.hwang@intel.com changed reviewers:
+ dongseong.hwang@intel.com

[dshwang, 2015-08-03 12:21:35]

lgtm with nits

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/common/gpu/ozo...
File ui/ozone/common/gpu/ozone_gpu_message_params.h (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/common/gpu/ozo...
ui/ozone/common/gpu/ozone_gpu_message_params.h:17: #include
"ui/ozone/public/surface_factory_ozone.h"
replace this header with buffer_types.h

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/gbm_buffer.h (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/gbm_buffer.h:14: #include
"ui/ozone/public/surface_factory_ozone.h"
replace this header with buffer_types.h

[dshwang, 2015-08-03 12:37:54]

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/gbm_surface_factory.cc (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/gbm_surface_factory.cc:115: if (usage != SCANOUT)
s/SCANOUT/gfx::BufferUsage::SCANOUT/

[spang, 2015-08-04 15:36:51]

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/common/gpu/ozo...
File ui/ozone/common/gpu/ozone_gpu_message_params.h (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/common/gpu/ozo...
ui/ozone/common/gpu/ozone_gpu_message_params.h:17: #include
"ui/ozone/public/surface_factory_ozone.h"
On 2015/08/03 12:21:35, dshwang wrote:
> replace this header with buffer_types.h

Done.

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/gbm_buffer.h (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/gbm_buffer.h:14: #include
"ui/ozone/public/surface_factory_ozone.h"
On 2015/08/03 12:21:35, dshwang wrote:
> replace this header with buffer_types.h

Done.

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/gbm_surface_factory.cc (right):

https://codereview.chromium.org/1269503007/diff/60001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/gbm_surface_factory.cc:115: if (usage != SCANOUT)
On 2015/08/03 12:37:54, dshwang wrote:
> s/SCANOUT/gfx::BufferUsage::SCANOUT/

Done.

[kenrb, 2015-08-04 15:39:07]

kenrb@chromium.org changed reviewers:
+ tsepez@chromium.org

[kenrb, 2015-08-04 15:39:08]

This looks ok to me but tsepez is the sole OWNER of
ui/gfx/ipc/gfx_param_traits.cc so I will punt the IPC review to him.

[Tom Sepez, 2015-08-04 16:20:11]

The messages themselves are fine, but do a build:

export GYP_DEFINES="enable_ipc_fuzzer=1"
gclient runhooks
ninja -C out/Debug ipc_fuzzer_all

If this fails to link, you'll want to ping me or mbarbell@. 
If it links, LGTM.

[spang, 2015-08-04 17:10:56]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 17:11:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269503007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269503007/100001

[spang, 2015-08-04 17:15:51]

On 2015/08/04 16:20:11, Tom Sepez wrote:
> The messages themselves are fine, but do a build:
> 
> export GYP_DEFINES="enable_ipc_fuzzer=1"
> gclient runhooks
> ninja -C out/Debug ipc_fuzzer_all
> 
> If this fails to link, you'll want to ping me or mbarbell@. 
> If it links, LGTM.

Tested, it links.

[sadrul, 2015-08-04 17:28:37]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2015-08-04 17:28:38]

ui lgtm

https://codereview.chromium.org/1269503007/diff/100001/ui/gfx/ipc/gfx_ipc.gyp
File ui/gfx/ipc/gfx_ipc.gyp (right):

https://codereview.chromium.org/1269503007/diff/100001/ui/gfx/ipc/gfx_ipc.gyp...
ui/gfx/ipc/gfx_ipc.gyp:29: 'gfx_param_traits_macros.h',
You need to update BUILD.gn too?

[spang, 2015-08-04 17:32:40]

https://codereview.chromium.org/1269503007/diff/100001/ui/gfx/ipc/gfx_ipc.gyp
File ui/gfx/ipc/gfx_ipc.gyp (right):

https://codereview.chromium.org/1269503007/diff/100001/ui/gfx/ipc/gfx_ipc.gyp...
ui/gfx/ipc/gfx_ipc.gyp:29: 'gfx_param_traits_macros.h',
On 2015/08/04 17:28:38, sadrul wrote:
> You need to update BUILD.gn too?

Done.

[spang, 2015-08-04 17:34:04]

spang@chromium.org changed reviewers:
+ jam@chromium.org

[spang, 2015-08-04 17:34:28]

TBR jam for API changes across the repo

[spang, 2015-08-04 17:34:37]

The CQ bit was checked by spang@chromium.org

[spang, 2015-08-04 17:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dongseong.hwang@intel.com, reveman@chromium.org, tsepez@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1269503007/#ps120001
(title: "add header to BUILD.gn")

[commit-bot: I haz the power, 2015-08-04 17:35:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269503007/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269503007/120001

[commit-bot: I haz the power, 2015-08-04 19:25:49]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-08-04 19:26:18]

Patchset 7 (id:??) landed as
https://crrev.com/fcf5fab44b781da53a711476c4d48950ecf764b3
Cr-Commit-Position: refs/heads/master@{#341758}