Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc

Issue 1269503007: Unify graphics buffer format & usage enums for GpuMemoryBuffer & SurfaceFactoryOzone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add header to BUILD.gn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc
diff --git a/content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc b/content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc
index 50997e6094dfd5d5fb24494606cbb5030a1f6629..6d4af6abd6c3f5614d19d3e5490e101ee047cfb4 100644
--- a/content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc
+++ b/content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc
@@ -15,16 +15,16 @@ namespace content {
namespace {
const GpuMemoryBufferFactory::Configuration kSupportedConfigurations[] = {
- {gfx::GpuMemoryBuffer::R_8, gfx::GpuMemoryBuffer::MAP},
- {gfx::GpuMemoryBuffer::R_8, gfx::GpuMemoryBuffer::PERSISTENT_MAP},
- {gfx::GpuMemoryBuffer::RGBA_4444, gfx::GpuMemoryBuffer::MAP},
- {gfx::GpuMemoryBuffer::RGBA_4444, gfx::GpuMemoryBuffer::PERSISTENT_MAP},
- {gfx::GpuMemoryBuffer::RGBA_8888, gfx::GpuMemoryBuffer::MAP},
- {gfx::GpuMemoryBuffer::RGBA_8888, gfx::GpuMemoryBuffer::PERSISTENT_MAP},
- {gfx::GpuMemoryBuffer::BGRA_8888, gfx::GpuMemoryBuffer::MAP},
- {gfx::GpuMemoryBuffer::BGRA_8888, gfx::GpuMemoryBuffer::PERSISTENT_MAP},
- {gfx::GpuMemoryBuffer::YUV_420, gfx::GpuMemoryBuffer::MAP},
- {gfx::GpuMemoryBuffer::YUV_420, gfx::GpuMemoryBuffer::PERSISTENT_MAP}};
+ {gfx::BufferFormat::R_8, gfx::BufferUsage::MAP},
+ {gfx::BufferFormat::R_8, gfx::BufferUsage::PERSISTENT_MAP},
+ {gfx::BufferFormat::RGBA_4444, gfx::BufferUsage::MAP},
+ {gfx::BufferFormat::RGBA_4444, gfx::BufferUsage::PERSISTENT_MAP},
+ {gfx::BufferFormat::RGBA_8888, gfx::BufferUsage::MAP},
+ {gfx::BufferFormat::RGBA_8888, gfx::BufferUsage::PERSISTENT_MAP},
+ {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::MAP},
+ {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::PERSISTENT_MAP},
+ {gfx::BufferFormat::YUV_420, gfx::BufferUsage::MAP},
+ {gfx::BufferFormat::YUV_420, gfx::BufferUsage::PERSISTENT_MAP}};
} // namespace
@@ -36,8 +36,8 @@ GpuMemoryBufferFactorySharedMemory::~GpuMemoryBufferFactorySharedMemory() {
// static
bool GpuMemoryBufferFactorySharedMemory::
- IsGpuMemoryBufferConfigurationSupported(gfx::GpuMemoryBuffer::Format format,
- gfx::GpuMemoryBuffer::Usage usage) {
+ IsGpuMemoryBufferConfigurationSupported(gfx::BufferFormat format,
+ gfx::BufferUsage usage) {
for (auto& configuration : kSupportedConfigurations) {
if (configuration.format == format && configuration.usage == usage)
return true;
@@ -58,8 +58,8 @@ gfx::GpuMemoryBufferHandle
GpuMemoryBufferFactorySharedMemory::CreateGpuMemoryBuffer(
gfx::GpuMemoryBufferId id,
const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format,
- gfx::GpuMemoryBuffer::Usage usage,
+ gfx::BufferFormat format,
+ gfx::BufferUsage usage,
int client_id,
gfx::PluginWindowHandle surface_handle) {
size_t buffer_size = 0u;
@@ -97,7 +97,7 @@ scoped_refptr<gfx::GLImage>
GpuMemoryBufferFactorySharedMemory::CreateImageForGpuMemoryBuffer(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format,
+ gfx::BufferFormat format,
unsigned internalformat,
int client_id) {
#if DCHECK_IS_ON()

Powered by Google App Engine
This is Rietveld 408576698