Deprecate LogCB in favor of using MediaLog

Deprecate LogCB in favor of using MediaLog

Now that MEDIA_LOG macros work with a MediaLog, and having a MediaLog
object is needed to log events like property changes (not just strings),
this CL replaces usage of bound LogCB with actual MediaLog object
throughout //media. It also removes LogCB.

BUG=499628
R=xhwang@chromium.org,chcunningham@chromium.org,gunsch@chromium.org
TEST=No media unittest or layout test regression locally on linux with proprietary codecs including mp2t enabled

Committed: https://crrev.com/1fb319dc2cfe72901db6303c37a38b0f6010adf9
Cr-Commit-Position: refs/heads/master@{#338710}

[wolenetz, 2015-07-13 22:22:32]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 22:23:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235793005/20001

[wolenetz, 2015-07-13 22:25:29]

Please take a look at patch set 2:
xhwang@: OWNER and committer review (everything)
gunsch@: media/formats/mp2t portion
chcunningham@: fyi, chime in if you want to.

I need a MediaLog, not a LogCB, in SourceBufferStream to fix bug 492833, so I've
taken on this deprecation work.

This is mostly mechanical, though I removed the LogCB->DVLOG(1) test helper
method which was not involved in any automated verification. Perhaps a later
change might add more test helpers specific to MediaLog, but I think those are
out of scope of this CL.

https://codereview.chromium.org/1235793005/diff/1/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

https://codereview.chromium.org/1235793005/diff/1/media/filters/chunk_demuxer...
media/filters/chunk_demuxer.h:168: // |enable_text| Process inband text tracks
in the normal way when true,
This was just a drive-by fix. This comment was previously in the wrong place.

https://codereview.chromium.org/1235793005/diff/1/media/filters/source_buffer...
File media/filters/source_buffer_stream.cc (right):

https://codereview.chromium.org/1235793005/diff/1/media/filters/source_buffer...
media/filters/source_buffer_stream.cc:118: audio_splice_count_(0),
Ditto oops, here and below! (PS2 fixes this CL to not have these.)

https://codereview.chromium.org/1235793005/diff/1/media/filters/source_buffer...
File media/filters/source_buffer_stream.h (right):

https://codereview.chromium.org/1235793005/diff/1/media/filters/source_buffer...
media/filters/source_buffer_stream.h:422: // Fields supporting statistics
reporting for audio splice frame generation.
Oops! These were from a CL I'll send later that depends on this
deprecation/plumbing... PS2 will remove this part of this change.

[xhwang, 2015-07-13 22:41:17]

Thanks for taking this! LGTM with a few nits.

https://codereview.chromium.org/1235793005/diff/20001/media/base/media_log.cc
File media/base/media_log.cc (right):

https://codereview.chromium.org/1235793005/diff/20001/media/base/media_log.cc...
media/base/media_log.cc:276: : level_(level), media_log_(media_log) {
DCHECK media_log so that you don't need the check on l.280?

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
File media/formats/webm/webm_cluster_parser_unittest.cc (right):

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
media/formats/webm/webm_cluster_parser_unittest.cc:287: std::string(),
kUnknownAudioCodec, new MediaLog()));
nit: It might make sense to have a helper function to create these
WebMClusterParsers. It's really hard to read this code here and below ;)

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
File media/formats/webm/webm_tracks_parser.h (right):

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
media/formats/webm/webm_tracks_parser.h:31: bool ignore_text_tracks);
s/explicit//

[xhwang, 2015-07-13 22:42:12]

It seems you also need to fix Android classes like media_source_delegate.cc,
WMPA etc.

[gunsch, 2015-07-13 22:48:19]

media/formats/mp2t lgtm

[commit-bot: I haz the power, 2015-07-13 22:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 22:50:16]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[wolenetz, 2015-07-13 22:59:24]

Thanks for reviews.
chcunningham@ did you want to take a look (at patch set 3)?

https://codereview.chromium.org/1235793005/diff/20001/media/base/media_log.cc
File media/base/media_log.cc (right):

https://codereview.chromium.org/1235793005/diff/20001/media/base/media_log.cc...
media/base/media_log.cc:276: : level_(level), media_log_(media_log) {
On 2015/07/13 22:41:17, xhwang wrote:
> DCHECK media_log so that you don't need the check on l.280?

Done.

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
File media/formats/webm/webm_cluster_parser_unittest.cc (right):

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
media/formats/webm/webm_cluster_parser_unittest.cc:287: std::string(),
kUnknownAudioCodec, new MediaLog()));
On 2015/07/13 22:41:17, xhwang wrote:
> nit: It might make sense to have a helper function to create these
> WebMClusterParsers. It's really hard to read this code here and below ;)

sgtm. I'll put those in a separate CL though. Thanks!

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
File media/formats/webm/webm_tracks_parser.h (right):

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
media/formats/webm/webm_tracks_parser.h:31: bool ignore_text_tracks);
On 2015/07/13 22:41:17, xhwang wrote:
> s/explicit//

Done.

[wolenetz, 2015-07-13 22:59:36]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 23:01:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235793005/40001

[commit-bot: I haz the power, 2015-07-14 00:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 00:07:58]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2015-07-14 17:41:30]

lgtm

[wolenetz, 2015-07-14 17:42:22]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2015-07-14 17:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
gunsch@chromium.org
Link to the patchset: https://codereview.chromium.org/1235793005/#ps40001
(title: "Address comments and attempt to fix Android compilation")

[commit-bot: I haz the power, 2015-07-14 17:42:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235793005/40001

[commit-bot: I haz the power, 2015-07-14 17:49:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-14 17:50:49]

Patchset 3 (id:??) landed as
https://crrev.com/1fb319dc2cfe72901db6303c37a38b0f6010adf9
Cr-Commit-Position: refs/heads/master@{#338710}

[wolenetz, 2015-07-21 00:57:59]

Regarding xhwang@'s comment on this:

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
File media/formats/webm/webm_cluster_parser_unittest.cc (right):

https://codereview.chromium.org/1235793005/diff/20001/media/formats/webm/webm...
media/formats/webm/webm_cluster_parser_unittest.cc:287: std::string(),
kUnknownAudioCodec, new MediaLog()));
On 2015/07/13 22:59:24, wolenetz wrote:
> On 2015/07/13 22:41:17, xhwang wrote:
> > nit: It might make sense to have a helper function to create these
> > WebMClusterParsers. It's really hard to read this code here and below ;)
> 
> sgtm. I'll put those in a separate CL though. Thanks!

I have now prepared the separate CL for review @
https://codereview.chromium.org/1242943003/