media/formats/mp2t/es_parser_mpeg1audio.h - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp2t/es_parser_mpeg1audio.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp2t/es_parser_mpeg1audio.h

diff --git a/media/formats/mp2t/es_parser_mpeg1audio.h b/media/formats/mp2t/es_parser_mpeg1audio.h

index c10f8fdfffac1917722b7e5c600df0f0cb99a629..6ffb197788a8dd28220a5a44dae815de80babac9 100644

--- a/media/formats/mp2t/es_parser_mpeg1audio.h

+++ b/media/formats/mp2t/es_parser_mpeg1audio.h

@@ -33,7 +33,7 @@ class MEDIA_EXPORT EsParserMpeg1Audio : public EsParser {

EsParserMpeg1Audio(const NewAudioConfigCB& new_audio_config_cb,

const EmitBufferCB& emit_buffer_cb,

- const LogCB& log_cb);

+ const scoped_refptr<MediaLog>& media_log);

~EsParserMpeg1Audio() override;

// EsParser implementation.

@@ -65,7 +65,7 @@ class MEDIA_EXPORT EsParserMpeg1Audio : public EsParser {

void SkipMpeg1AudioFrame(const Mpeg1AudioFrame& mpeg1audio_frame);

- LogCB log_cb_;

+ scoped_refptr<MediaLog> media_log_;

// Callbacks:

// - to signal a new audio configuration,