media/formats/mp4/box_definitions.h - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/box_definitions.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp4/box_definitions.h

diff --git a/media/formats/mp4/box_definitions.h b/media/formats/mp4/box_definitions.h

index 2dfab63b5d17c06ad1fc0dd56151ebd5057a2249..e586364559c8ff759ce0d375830a1b3be182636a 100644

--- a/media/formats/mp4/box_definitions.h

+++ b/media/formats/mp4/box_definitions.h

@@ -185,7 +185,8 @@ struct MEDIA_EXPORT AVCDecoderConfigurationRecord : Box {

std::vector<PPS> pps_list;

private:

- bool ParseInternal(BufferReader* reader, const LogCB& log_cb);

+ bool ParseInternal(BufferReader* reader,

+ const scoped_refptr<MediaLog>& media_log);

};

struct MEDIA_EXPORT PixelAspectRatioBox : Box {

« no previous file with comments | « media/formats/mp4/aac_unittest.cc ('k') | media/formats/mp4/box_definitions.cc » ('j') | no next file with comments »