media/formats/mpeg/mpeg1_audio_stream_parser.h - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg1_audio_stream_parser.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/mpeg1_audio_stream_parser.h

diff --git a/media/formats/mpeg/mpeg1_audio_stream_parser.h b/media/formats/mpeg/mpeg1_audio_stream_parser.h

index b2e5086f8471e8cb28f669271ab19bd65309b38c..3b299a105bd07b952abd7d2d94d8f6d18293b8d1 100644

--- a/media/formats/mpeg/mpeg1_audio_stream_parser.h

+++ b/media/formats/mpeg/mpeg1_audio_stream_parser.h

@@ -62,10 +62,9 @@ class MEDIA_EXPORT MPEG1AudioStreamParser : public MPEGAudioStreamParserBase {

// Parses the header starting at |data|.

// Assumption: size of array |data| should be at least |kHeaderSize|.

// Returns false if the header is not valid.

- static bool ParseHeader(

- const LogCB& log_cb,

- const uint8* data,

- Header* header);

+ static bool ParseHeader(const scoped_refptr<MediaLog>& media_log,

+ const uint8* data,

+ Header* header);

MPEG1AudioStreamParser();

~MPEG1AudioStreamParser() override;