Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: media/filters/stream_parser_factory.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/source_buffer_stream_unittest.cc ('k') | media/filters/stream_parser_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/stream_parser_factory.h
diff --git a/media/filters/stream_parser_factory.h b/media/filters/stream_parser_factory.h
index 1f9ad347d12e214dd7fa2730d7acfa2b205b75c8..3bbd58ab9bec2adb4585c0f21527e1c5da7630bb 100644
--- a/media/filters/stream_parser_factory.h
+++ b/media/filters/stream_parser_factory.h
@@ -24,8 +24,8 @@ class MEDIA_EXPORT StreamParserFactory {
const std::string& type, const std::vector<std::string>& codecs);
// Creates a new StreamParser object if the specified |type| and |codecs| list
- // are supported. |log_cb| can be used to report errors if there is something
- // wrong with |type| or the codec IDs in |codecs|.
+ // are supported. |media_log| can be used to report errors if there is
+ // something wrong with |type| or the codec IDs in |codecs|.
// Returns a new StreamParser object if |type| and all codecs listed in
// |codecs| are supported.
// |has_audio| is true if an audio codec was specified.
@@ -33,8 +33,11 @@ class MEDIA_EXPORT StreamParserFactory {
// Returns NULL otherwise. The values of |has_audio| and |has_video| are
// undefined.
static scoped_ptr<StreamParser> Create(
- const std::string& type, const std::vector<std::string>& codecs,
- const LogCB& log_cb, bool* has_audio, bool* has_video);
+ const std::string& type,
+ const std::vector<std::string>& codecs,
+ const scoped_refptr<MediaLog>& media_log,
+ bool* has_audio,
+ bool* has_video);
};
} // namespace media
« no previous file with comments | « media/filters/source_buffer_stream_unittest.cc ('k') | media/filters/stream_parser_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698