media/formats/webm/webm_content_encodings_client_unittest.cc - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_content_encodings_client_unittest.cc

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/webm/webm_content_encodings_client_unittest.cc

diff --git a/media/formats/webm/webm_content_encodings_client_unittest.cc b/media/formats/webm/webm_content_encodings_client_unittest.cc

index e124f2d883ae9d745a255d3edf3a82a51279bc6d..22049ebfce74ec0bf1faaa84132342de180a3a7f 100644

--- a/media/formats/webm/webm_content_encodings_client_unittest.cc

+++ b/media/formats/webm/webm_content_encodings_client_unittest.cc

@@ -13,8 +13,7 @@ namespace media {

class WebMContentEncodingsClientTest : public testing::Test {

public:

WebMContentEncodingsClientTest()

- : client_(LogCB()),

- parser_(kWebMIdContentEncodings, &client_) {}

+ : client_(new MediaLog()), parser_(kWebMIdContentEncodings, &client_) {}

void ParseAndExpectToFail(const uint8* buf, int size) {

int result = parser_.Parse(buf, size);