media/formats/mpeg/adts_stream_parser.cc - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/adts_stream_parser.cc

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/adts_stream_parser.cc

diff --git a/media/formats/mpeg/adts_stream_parser.cc b/media/formats/mpeg/adts_stream_parser.cc

index ea0f5923096a3e1f238a5805bf218944ae4de317..a59d9ba219d45630e9cd34504fc075d08b11704e 100644

--- a/media/formats/mpeg/adts_stream_parser.cc

+++ b/media/formats/mpeg/adts_stream_parser.cc

@@ -69,7 +69,7 @@ int ADTSStreamParser::ParseFrameHeader(const uint8* data,

if (sync != 0xfff || layer != 0 || frame_length < bytes_read ||

sample_rate_index >= kADTSFrequencyTableSize ||

channel_layout_index >= kADTSChannelLayoutTableSize) {

- MEDIA_LOG(DEBUG, log_cb())

+ MEDIA_LOG(DEBUG, media_log())

<< "Invalid header data :" << std::hex << " sync 0x" << sync

<< " version 0x" << version << " layer 0x" << layer

<< " sample_rate_index 0x" << sample_rate_index