media/formats/webm/webm_stream_parser.h - Issue 1235793005: Deprecate LogCB in favor of using MediaLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_stream_parser.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/webm/webm_stream_parser.h

diff --git a/media/formats/webm/webm_stream_parser.h b/media/formats/webm/webm_stream_parser.h

index e808413c712be5bea60975460b63e17a79349ad4..cb95804f097d5e05430ccda0c69a2e2319e62e0e 100644

--- a/media/formats/webm/webm_stream_parser.h

+++ b/media/formats/webm/webm_stream_parser.h

@@ -30,7 +30,7 @@ class WebMStreamParser : public StreamParser {

const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,

const NewMediaSegmentCB& new_segment_cb,

const base::Closure& end_of_segment_cb,

- const LogCB& log_cb) override;

+ const scoped_refptr<MediaLog>& media_log) override;

void Flush() override;

bool Parse(const uint8* buf, int size) override;

@@ -75,7 +75,7 @@ class WebMStreamParser : public StreamParser {

NewMediaSegmentCB new_segment_cb_;

base::Closure end_of_segment_cb_;

- LogCB log_cb_;

+ scoped_refptr<MediaLog> media_log_;

bool unknown_segment_size_;