Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2195)

Unified Diff: media/formats/mp4/aac.cc

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/aac.h ('k') | media/formats/mp4/aac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/aac.cc
diff --git a/media/formats/mp4/aac.cc b/media/formats/mp4/aac.cc
index bbfd4f57854d99e993baedd046e8bacd8c04b874..9aa749ca310cffe9eb0520c8c2c6395da439c4f0 100644
--- a/media/formats/mp4/aac.cc
+++ b/media/formats/mp4/aac.cc
@@ -22,7 +22,8 @@ AAC::AAC()
AAC::~AAC() {
}
-bool AAC::Parse(const std::vector<uint8>& data, const LogCB& log_cb) {
+bool AAC::Parse(const std::vector<uint8>& data,
+ const scoped_refptr<MediaLog>& media_log) {
#if defined(OS_ANDROID)
codec_specific_data_ = data;
#endif
@@ -57,8 +58,8 @@ bool AAC::Parse(const std::vector<uint8>& data, const LogCB& log_cb) {
RCHECK(reader.ReadBits(5, &profile_));
}
- MEDIA_LOG(INFO, log_cb) << "Audio codec: mp4a.40." << std::hex
- << static_cast<int>(profile_);
+ MEDIA_LOG(INFO, media_log) << "Audio codec: mp4a.40." << std::hex
+ << static_cast<int>(profile_);
RCHECK(SkipDecoderGASpecificConfig(&reader));
RCHECK(SkipErrorSpecificConfig());
« no previous file with comments | « media/formats/mp4/aac.h ('k') | media/formats/mp4/aac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698