Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: media/formats/mpeg/mpeg1_audio_stream_parser.cc

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and attempt to fix Android compilation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/mpeg/mpeg1_audio_stream_parser.h" 5 #include "media/formats/mpeg/mpeg1_audio_stream_parser.h"
6 6
7 namespace media { 7 namespace media {
8 8
9 static const uint32 kMPEG1StartCodeMask = 0xffe00000; 9 static const uint32 kMPEG1StartCodeMask = 0xffe00000;
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 static const int kXingHeaderMap[2][2] = {{32, 17}, {17, 9}}; 80 static const int kXingHeaderMap[2][2] = {{32, 17}, {17, 9}};
81 81
82 // Frame header field constants. 82 // Frame header field constants.
83 static const int kBitrateFree = 0; 83 static const int kBitrateFree = 0;
84 static const int kBitrateBad = 0xf; 84 static const int kBitrateBad = 0xf;
85 static const int kSampleRateReserved = 3; 85 static const int kSampleRateReserved = 3;
86 static const int kCodecDelay = 529; 86 static const int kCodecDelay = 529;
87 87
88 // static 88 // static
89 bool MPEG1AudioStreamParser::ParseHeader( 89 bool MPEG1AudioStreamParser::ParseHeader(
90 const LogCB& log_cb, 90 const scoped_refptr<MediaLog>& media_log,
91 const uint8* data, 91 const uint8* data,
92 Header* header) { 92 Header* header) {
93 BitReader reader(data, kHeaderSize); 93 BitReader reader(data, kHeaderSize);
94 int sync; 94 int sync;
95 int version; 95 int version;
96 int layer; 96 int layer;
97 int is_protected; 97 int is_protected;
98 int bitrate_index; 98 int bitrate_index;
99 int sample_rate_index; 99 int sample_rate_index;
100 int has_padding; 100 int has_padding;
(...skipping 20 matching lines...) Expand all
121 << " layer 0x" << layer 121 << " layer 0x" << layer
122 << " bitrate_index 0x" << bitrate_index 122 << " bitrate_index 0x" << bitrate_index
123 << " sample_rate_index 0x" << sample_rate_index 123 << " sample_rate_index 0x" << sample_rate_index
124 << " channel_mode 0x" << channel_mode; 124 << " channel_mode 0x" << channel_mode;
125 125
126 if (sync != 0x7ff || 126 if (sync != 0x7ff ||
127 version == kVersionReserved || 127 version == kVersionReserved ||
128 layer == kLayerReserved || 128 layer == kLayerReserved ||
129 bitrate_index == kBitrateFree || bitrate_index == kBitrateBad || 129 bitrate_index == kBitrateFree || bitrate_index == kBitrateBad ||
130 sample_rate_index == kSampleRateReserved) { 130 sample_rate_index == kSampleRateReserved) {
131 MEDIA_LOG(ERROR, log_cb) 131 MEDIA_LOG(ERROR, media_log)
132 << "Invalid header data :" << std::hex << " sync 0x" << sync 132 << "Invalid header data :" << std::hex << " sync 0x" << sync
133 << " version 0x" << version << " layer 0x" << layer 133 << " version 0x" << version << " layer 0x" << layer
134 << " bitrate_index 0x" << bitrate_index << " sample_rate_index 0x" 134 << " bitrate_index 0x" << bitrate_index << " sample_rate_index 0x"
135 << sample_rate_index << " channel_mode 0x" << channel_mode; 135 << sample_rate_index << " channel_mode 0x" << channel_mode;
136 return false; 136 return false;
137 } 137 }
138 138
139 if (layer == kLayer2 && kIsAllowed[bitrate_index][channel_mode]) { 139 if (layer == kLayer2 && kIsAllowed[bitrate_index][channel_mode]) {
140 MEDIA_LOG(ERROR, log_cb) << "Invalid (bitrate_index, channel_mode)" 140 MEDIA_LOG(ERROR, media_log) << "Invalid (bitrate_index, channel_mode)"
141 << " combination :" << std::hex 141 << " combination :" << std::hex
142 << " bitrate_index " << bitrate_index 142 << " bitrate_index " << bitrate_index
143 << " channel_mode " << channel_mode; 143 << " channel_mode " << channel_mode;
144 return false; 144 return false;
145 } 145 }
146 146
147 int bitrate = kBitrateMap[bitrate_index][kVersionLayerMap[version][layer]]; 147 int bitrate = kBitrateMap[bitrate_index][kVersionLayerMap[version][layer]];
148 148
149 if (bitrate == 0) { 149 if (bitrate == 0) {
150 MEDIA_LOG(ERROR, log_cb) << "Invalid bitrate :" << std::hex << " version " 150 MEDIA_LOG(ERROR, media_log) << "Invalid bitrate :" << std::hex
151 << version << " layer " << layer 151 << " version " << version << " layer " << layer
152 << " bitrate_index " << bitrate_index; 152 << " bitrate_index " << bitrate_index;
153 return false; 153 return false;
154 } 154 }
155 155
156 DVLOG(2) << " bitrate " << bitrate; 156 DVLOG(2) << " bitrate " << bitrate;
157 157
158 int frame_sample_rate = kSampleRateMap[sample_rate_index][version]; 158 int frame_sample_rate = kSampleRateMap[sample_rate_index][version];
159 if (frame_sample_rate == 0) { 159 if (frame_sample_rate == 0) {
160 MEDIA_LOG(ERROR, log_cb) << "Invalid sample rate :" << std::hex 160 MEDIA_LOG(ERROR, media_log) << "Invalid sample rate :" << std::hex
161 << " version " << version << " sample_rate_index " 161 << " version " << version
162 << sample_rate_index; 162 << " sample_rate_index " << sample_rate_index;
163 return false; 163 return false;
164 } 164 }
165 header->sample_rate = frame_sample_rate; 165 header->sample_rate = frame_sample_rate;
166 166
167 // http://teslabs.com/openplayer/docs/docs/specs/mp3_structure2.pdf 167 // http://teslabs.com/openplayer/docs/docs/specs/mp3_structure2.pdf
168 // Table 2.1.5 168 // Table 2.1.5
169 int samples_per_frame; 169 int samples_per_frame;
170 switch (layer) { 170 switch (layer) {
171 case kLayer1: 171 case kLayer1:
172 samples_per_frame = 384; 172 samples_per_frame = 384;
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 int* sample_count, 229 int* sample_count,
230 bool* metadata_frame) const { 230 bool* metadata_frame) const {
231 DCHECK(data); 231 DCHECK(data);
232 DCHECK_GE(size, 0); 232 DCHECK_GE(size, 0);
233 DCHECK(frame_size); 233 DCHECK(frame_size);
234 234
235 if (size < kHeaderSize) 235 if (size < kHeaderSize)
236 return 0; 236 return 0;
237 237
238 Header header; 238 Header header;
239 if (!ParseHeader(log_cb(), data, &header)) 239 if (!ParseHeader(media_log(), data, &header))
240 return -1; 240 return -1;
241 241
242 *frame_size = header.frame_size; 242 *frame_size = header.frame_size;
243 if (sample_rate) 243 if (sample_rate)
244 *sample_rate = header.sample_rate; 244 *sample_rate = header.sample_rate;
245 if (sample_count) 245 if (sample_count)
246 *sample_count = header.sample_count; 246 *sample_count = header.sample_count;
247 if (channel_layout) 247 if (channel_layout)
248 *channel_layout = header.channel_layout; 248 *channel_layout = header.channel_layout;
249 if (metadata_frame) 249 if (metadata_frame)
(...skipping 18 matching lines...) Expand all
268 // If we don't have enough data available to check, return 0 so frame parsing 268 // If we don't have enough data available to check, return 0 so frame parsing
269 // will be retried once more data is available. 269 // will be retried once more data is available.
270 BitReader reader(data + header_bytes_read, size - header_bytes_read); 270 BitReader reader(data + header_bytes_read, size - header_bytes_read);
271 if (!reader.SkipBits(xing_header_index * 8) || 271 if (!reader.SkipBits(xing_header_index * 8) ||
272 !reader.ReadBits(sizeof(tag) * 8, &tag)) { 272 !reader.ReadBits(sizeof(tag) * 8, &tag)) {
273 return 0; 273 return 0;
274 } 274 }
275 275
276 // Check to see if the tag contains 'Xing' or 'Info' 276 // Check to see if the tag contains 'Xing' or 'Info'
277 if (tag == 0x496e666f || tag == 0x58696e67) { 277 if (tag == 0x496e666f || tag == 0x58696e67) {
278 MEDIA_LOG(DEBUG, log_cb()) << "Skipping XING header."; 278 MEDIA_LOG(DEBUG, media_log()) << "Skipping XING header.";
279 if (metadata_frame) 279 if (metadata_frame)
280 *metadata_frame = true; 280 *metadata_frame = true;
281 return header_bytes_read + reader.bits_read() / 8; 281 return header_bytes_read + reader.bits_read() / 8;
282 } 282 }
283 283
284 // If it wasn't a XING frame, just return the number consumed bytes. 284 // If it wasn't a XING frame, just return the number consumed bytes.
285 return header_bytes_read; 285 return header_bytes_read;
286 } 286 }
287 287
288 } // namespace media 288 } // namespace media
OLDNEW
« no previous file with comments | « media/formats/mpeg/mpeg1_audio_stream_parser.h ('k') | media/formats/mpeg/mpeg_audio_stream_parser_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698