Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, shans, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, aboxhall, blink-reviews-css, szager+layoutwatch_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, devtools-reviews_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, dmazzoni, darktears, Stephen Chennney, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, nektarios, f(malita), groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Make CSSPrimitiveValue a container Make CSSPrimitiveValue a ref-counted container that stores a CSSLargePrimitiveValue*. This will later allow CSSPrimitiveValue to store a tagged pointer, where possible, instead of an object. Depends on crrev.com/1164573002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Fixed oilpan issues #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed rebase #

Patch Set 5 : Rebase and small amount of more work #

Patch Set 6 : Rebase #

Patch Set 7 : Fixed small bug and rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1636 lines, -1500 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolationTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/ImageSliceStyleInterpolation.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ListStyleInterpolationTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolationTest.cpp View 3 chunks +26 lines, -26 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknownTest.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 1 12 chunks +59 lines, -59 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 11 chunks +45 lines, -45 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 2 3 4 5 6 7 8 8 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSContentDistributionValue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 1 2 3 4 5 7 chunks +28 lines, -28 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 22 chunks +81 lines, -79 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 2 8 chunks +183 lines, -102 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 17 chunks +84 lines, -71 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 194 chunks +216 lines, -216 lines 0 comments Download
M Source/core/css/CSSReflectValue.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSReflectValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSShadowValue.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSShadowValue.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 5 chunks +25 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueObject.cpp View 1 6 chunks +17 lines, -5 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSValueTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSValueTestHelper.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 16 chunks +50 lines, -50 lines 0 comments Download
M Source/core/css/Counter.h View 1 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/FontFace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/Pair.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/Rect.h View 1 4 chunks +20 lines, -20 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 2 10 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 112 chunks +229 lines, -228 lines 0 comments Download
M Source/core/css/parser/SizesCalcParserTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 17 chunks +44 lines, -44 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 34 chunks +85 lines, -86 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 18 chunks +20 lines, -20 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/TextLinkColors.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextLinkColors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 2 3 4 19 chunks +42 lines, -42 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLength.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1164573002 Patch 770001

Dependent Patchsets:

Issue 1226273002 Patch 60001

Messages

Total messages: 3 (2 generated)
sashab
5 years, 5 months ago (2015-07-09 04:10:38 UTC) #2 

          

          

        


      

    
      
    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698