Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: Source/core/css/CSSValueTest.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValuePool.cpp ('k') | Source/core/css/CSSValueTestHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValueTest.cpp
diff --git a/Source/core/css/CSSValueTest.cpp b/Source/core/css/CSSValueTest.cpp
index 78d2205e932d4e793d5d3e24310f5cad1baf18d4..08682ebd8b0234294bc36b360a290267483c10dc 100644
--- a/Source/core/css/CSSValueTest.cpp
+++ b/Source/core/css/CSSValueTest.cpp
@@ -14,18 +14,18 @@ using namespace blink;
namespace {
// Helper functions since PassRefPtrWillBeRawPtr cannot be a member variable.
-CSSValue makeCSSValueWithPassRefPtr(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> primitiveValue)
+CSSValue makeCSSValueWithPassRefPtr(CSSPrimitiveValue primitiveValue)
{
return CSSValue(primitiveValue);
}
-NullableCSSValue makeNullableCSSValueWithPassRefPtr(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> primitiveValue)
+NullableCSSValue makeNullableCSSValueWithPassRefPtr(CSSPrimitiveValue primitiveValue)
{
return NullableCSSValue(primitiveValue);
}
TEST(CSSValueTest, CSSValueTest)
{
- RefPtrWillBeRawPtr<CSSPrimitiveValue> primitiveValueRef = CSSPrimitiveValue::createIdentifier(CSSValueBold);
+ CSSPrimitiveValue primitiveValueRef = CSSPrimitiveValue::createIdentifier(CSSValueBold);
CSSValue passRefPtrConstructor = makeCSSValueWithPassRefPtr(CSSPrimitiveValue::createIdentifier(CSSValueBold));
EXPECT_STREQ("bold", passRefPtrConstructor.cssText().utf8().data());
@@ -56,7 +56,7 @@ TEST(CSSValueTest, CSSValueTest)
TEST(CSSValueTest, NullableCSSValueTest)
{
- RefPtrWillBeRawPtr<CSSPrimitiveValue> primitiveValueRef = CSSPrimitiveValue::createIdentifier(CSSValueBold);
+ CSSPrimitiveValue primitiveValueRef = CSSPrimitiveValue::createIdentifier(CSSValueBold);
NullableCSSValue defaultConstructor;
EXPECT_FALSE(defaultConstructor);
« no previous file with comments | « Source/core/css/CSSValuePool.cpp ('k') | Source/core/css/CSSValueTestHelper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698