Issue 1226273002: CSSValue Immediates: Make CSSPrimitiveValue store a tagged pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226273002: CSSValue Immediates: Make CSSPrimitiveValue store a tagged pointer (Closed)

Created:
5 years, 5 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_2_attempt_2

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Make CSSPrimitiveValue store a tagged pointer Make the CSSPrimitiveValue store tagged pointers of doubles, colors, valueIDs and propertyIDs, where possible. Depends on crrev.com/1225553002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+464 lines, -94 lines)			Patch
M	Source/core/core.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.h	View	1 2	9 chunks	+235 lines, -46 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View		2 chunks	+10 lines, -6 lines	0 comments	Download
A	Source/core/css/CSSPrimitiveValueTest.cpp	View		1 chunk	+143 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSValue.h	View		11 chunks	+74 lines, -41 lines	0 comments	Download
M	Source/core/css/CSSValueObject.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1225553002 Patch 160001

Dependent Patchsets:

Issue 1261763005 Patch 20001

Issue 1234763007 Patch 60001

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages