Source/core/animation/DoubleStyleInterpolation.cpp - Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DoubleStyleInterpolation.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/DeferredLegacyStyleInterpolation.cpp ('k') | Source/core/animation/DoubleStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/DoubleStyleInterpolation.cpp

diff --git a/Source/core/animation/DoubleStyleInterpolation.cpp b/Source/core/animation/DoubleStyleInterpolation.cpp

index 38ff7677d8b6bcccd1c7ccc5869c46a6c11197e2..68a91d7507c40e23ca36817b9bd368149964741c 100644

--- a/Source/core/animation/DoubleStyleInterpolation.cpp

+++ b/Source/core/animation/DoubleStyleInterpolation.cpp

@@ -18,7 +18,7 @@ bool DoubleStyleInterpolation::canCreateFrom(const CSSValue& value)

PassOwnPtrWillBeRawPtr<InterpolableValue> DoubleStyleInterpolation::doubleToInterpolableValue(const CSSValue& value)

{

ASSERT(canCreateFrom(value));

- const CSSPrimitiveValue& primitive = toCSSPrimitiveValue(value);

+ const CSSPrimitiveValue primitive = toCSSPrimitiveValue(value);

if (primitive.isNumber())

return InterpolableNumber::create(primitive.getDoubleValue());

if (primitive.isAngle())

@@ -105,7 +105,7 @@ bool extractMotionRotation(const CSSValue& value, float* rotation, MotionRotatio

const CSSValue item = list.item(i);

if (!item.isPrimitiveValue())

return false;

- const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(item);

+ const CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(item);

if (primitiveValue.getValueID() == CSSValueAuto) {

*rotationType = MotionRotationAuto;

} else if (primitiveValue.getValueID() == CSSValueReverse) {