CSSValue Immediates: Make CSSPrimitiveValue a container

Source/core/animation/DeferredLegacyStyleInterpolation.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/DeferredLegacyStyleInterpolation.h"
 
 #include "core/animation/ElementAnimations.h"
 #include "core/animation/css/CSSAnimatableValueFactory.h"
 #include "core/css/CSSBasicShapes.h"
@@ skipping 25 matching lines @@
         }
 
         m_innerInterpolation = LegacyStyleInterpolation::create(startAnimatableValue, endAnimatableValue, m_id);
         m_outdated = false;
     }
 
     m_innerInterpolation->interpolate(m_cachedIteration, m_cachedFraction);
     m_innerInterpolation->apply(state);
 }
 
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue& value)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue value)
 {
     // FIXME: should not require resolving styles for inherit/initial/unset.
     if (value.isCSSWideKeyword())
         return true;
     if (value.isPrimitiveValue())
         return interpolationRequiresStyleResolve(toCSSPrimitiveValue(value));
     if (value.isValueList())
         return interpolationRequiresStyleResolve(toCSSValueList(value));
     if (value.isImageValue())
         return interpolationRequiresStyleResolve(toCSSImageValue(value));
     if (value.isShadowValue())
         return interpolationRequiresStyleResolve(toCSSShadowValue(value));
     if (value.isSVGDocumentValue())
         return interpolationRequiresStyleResolve(toCSSSVGDocumentValue(value));
     // FIXME: consider other custom types.
     return true;
 }
 
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue& primitiveValue)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue primitiveValue)
 {
     // FIXME: consider other types.
     if (primitiveValue.isNumber() || primitiveValue.isPercentage() || primitiveValue.isAngle() || primitiveValue.isRGBColor() || primitiveValue.isURI())
         return false;
 
     if (primitiveValue.isLength())
         return primitiveValue.isFontRelativeLength() || primitiveValue.isViewportPercentageLength();
 
     if (primitiveValue.isCalculated()) {
         CSSLengthArray lengthArray(CSSPrimitiveValue::LengthUnitTypeCount);
         primitiveValue.accumulateLengthArray(lengthArray);
         return lengthArray[CSSPrimitiveValue::UnitTypeFontSize] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeFontXSize] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeRootFontSize] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeZeroCharacterWidth] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeViewportWidth] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeViewportHeight] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeViewportMin] != 0
             || lengthArray[CSSPrimitiveValue::UnitTypeViewportMax] != 0;
     }
 
     if (Pair* pair = primitiveValue.getPairValue()) {
         return interpolationRequiresStyleResolve(*pair->first())
             || interpolationRequiresStyleResolve(*pair->second());
     }
 
     if (Rect* rect = primitiveValue.getRectValue()) {
-        return interpolationRequiresStyleResolve(*rect->top())
-            || interpolationRequiresStyleResolve(*rect->right())
-            || interpolationRequiresStyleResolve(*rect->bottom())
-            || interpolationRequiresStyleResolve(*rect->left());
+        return interpolationRequiresStyleResolve(rect->top())
+            || interpolationRequiresStyleResolve(rect->right())
+            || interpolationRequiresStyleResolve(rect->bottom())
+            || interpolationRequiresStyleResolve(rect->left());
     }
 
     if (Quad* quad = primitiveValue.getQuadValue()) {
-        return interpolationRequiresStyleResolve(*quad->top())
-            || interpolationRequiresStyleResolve(*quad->right())
-            || interpolationRequiresStyleResolve(*quad->bottom())
-            || interpolationRequiresStyleResolve(*quad->left());
+        return interpolationRequiresStyleResolve(quad->top())
+            || interpolationRequiresStyleResolve(quad->right())
+            || interpolationRequiresStyleResolve(quad->bottom())
+            || interpolationRequiresStyleResolve(quad->left());
     }
 
     if (primitiveValue.isShape())
         return interpolationRequiresStyleResolve(*primitiveValue.getShapeValue());
 
     CSSValueID id = primitiveValue.getValueID();
     bool isColor = ((id >= CSSValueAqua && id <= CSSValueTransparent)
         || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen)
         || id == CSSValueGrey);
     return (id != CSSValueNone) && !isColor;
@@ skipping 37 matching lines @@
 
 DEFINE_TRACE(DeferredLegacyStyleInterpolation)
 {
     visitor->trace(m_startCSSValue);
     visitor->trace(m_endCSSValue);
     visitor->trace(m_innerInterpolation);
     StyleInterpolation::trace(visitor);
 }
 
 }