Source/core/editing/EditorCommand.cpp - Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/EditorCommand.cpp

diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp

index 55a45a821997c6d3657c27a30a0de851787f6fff..9b8268effcfe3ffd002e56dcdb4bc3d5a75981b3 100644

--- a/Source/core/editing/EditorCommand.cpp

+++ b/Source/core/editing/EditorCommand.cpp

@@ -1117,8 +1117,8 @@ static bool executeTranspose(LocalFrame& frame, Event*, EditorCommandSource, con

static bool executeUnderline(LocalFrame& frame, Event*, EditorCommandSource source, const String&)

{

- RefPtrWillBeRawPtr<CSSPrimitiveValue> underline = CSSPrimitiveValue::createIdentifier(CSSValueUnderline);

- return executeToggleStyleInList(frame, source, EditActionUnderline, CSSPropertyWebkitTextDecorationsInEffect, CSSValue(*underline));

+ CSSPrimitiveValue underline = CSSPrimitiveValue::createIdentifier(CSSValueUnderline);

+ return executeToggleStyleInList(frame, source, EditActionUnderline, CSSPropertyWebkitTextDecorationsInEffect, underline);

}

static bool executeUndo(LocalFrame& frame, Event*, EditorCommandSource, const String&)

« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »