Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: Source/core/css/CSSShadowValue.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSShadowValue.cpp
diff --git a/Source/core/css/CSSShadowValue.cpp b/Source/core/css/CSSShadowValue.cpp
index 260250441f4c3ee057843cce4bb1e9ce25e05d00..2b25ab08edecab51c13bfed9390a25e3306c69ca 100644
--- a/Source/core/css/CSSShadowValue.cpp
+++ b/Source/core/css/CSSShadowValue.cpp
@@ -27,12 +27,12 @@
namespace blink {
// Used for text-shadow and box-shadow
-CSSShadowValue::CSSShadowValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> x,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> y,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> blur,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> spread,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> style,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> color)
+CSSShadowValue::CSSShadowValue(NullableCSSValue x,
+ NullableCSSValue y,
+ NullableCSSValue blur,
+ NullableCSSValue spread,
+ NullableCSSValue style,
+ NullableCSSValue color)
: CSSValueObject(ShadowClass)
, x(x)
, y(y)
@@ -80,12 +80,12 @@ String CSSShadowValue::customCSSText() const
bool CSSShadowValue::equals(const CSSShadowValue& other) const
{
- return compareCSSValuePtr(color, other.color)
- && compareCSSValuePtr(x, other.x)
- && compareCSSValuePtr(y, other.y)
- && compareCSSValuePtr(blur, other.blur)
- && compareCSSValuePtr(spread, other.spread)
- && compareCSSValuePtr(style, other.style);
+ return color == other.color
+ && x == other.x
+ && y == other.y
+ && blur == other.blur
+ && spread == other.spread
+ && style == other.style;
}
DEFINE_TRACE_AFTER_DISPATCH(CSSShadowValue)
« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698