Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp
diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
index 6c1ebfd56fbd0a04bb5af9f8cdbee3b5d33c5f03..f570881f20558bc058806bc540547a4871681083 100644
--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
@@ -43,7 +43,7 @@ void DeferredLegacyStyleInterpolation::apply(StyleResolverState& state) const
m_innerInterpolation->apply(state);
}
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue& value)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue value)
{
// FIXME: should not require resolving styles for inherit/initial/unset.
if (value.isCSSWideKeyword())
@@ -62,7 +62,7 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
return true;
}
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue& primitiveValue)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue primitiveValue)
{
// FIXME: consider other types.
if (primitiveValue.isNumber() || primitiveValue.isPercentage() || primitiveValue.isAngle() || primitiveValue.isRGBColor() || primitiveValue.isURI())
@@ -90,17 +90,17 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
}
if (Rect* rect = primitiveValue.getRectValue()) {
- return interpolationRequiresStyleResolve(*rect->top())
- || interpolationRequiresStyleResolve(*rect->right())
- || interpolationRequiresStyleResolve(*rect->bottom())
- || interpolationRequiresStyleResolve(*rect->left());
+ return interpolationRequiresStyleResolve(rect->top())
+ || interpolationRequiresStyleResolve(rect->right())
+ || interpolationRequiresStyleResolve(rect->bottom())
+ || interpolationRequiresStyleResolve(rect->left());
}
if (Quad* quad = primitiveValue.getQuadValue()) {
- return interpolationRequiresStyleResolve(*quad->top())
- || interpolationRequiresStyleResolve(*quad->right())
- || interpolationRequiresStyleResolve(*quad->bottom())
- || interpolationRequiresStyleResolve(*quad->left());
+ return interpolationRequiresStyleResolve(quad->top())
+ || interpolationRequiresStyleResolve(quad->right())
+ || interpolationRequiresStyleResolve(quad->bottom())
+ || interpolationRequiresStyleResolve(quad->left());
}
if (primitiveValue.isShape())
« no previous file with comments | « Source/core/animation/DeferredLegacyStyleInterpolation.h ('k') | Source/core/animation/DoubleStyleInterpolation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698