Source/core/inspector/LayoutEditor.cpp - Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/LayoutEditor.cpp

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/LayoutEditor.cpp

diff --git a/Source/core/inspector/LayoutEditor.cpp b/Source/core/inspector/LayoutEditor.cpp

index 81dc8cb7fb42aab04d74d65940af8627fbd0833e..a687d3401251a7f02694f155ebc44deb87482bca 100644

--- a/Source/core/inspector/LayoutEditor.cpp

+++ b/Source/core/inspector/LayoutEditor.cpp

@@ -149,7 +149,7 @@ PassRefPtr<JSONObject> LayoutEditor::createValueDescription(const String& proper

return nullptr;

RefPtr<JSONObject> object = JSONObject::create();

- object->setNumber("value", toCSSPrimitiveValue(cssValue)->getFloatValue());

+ object->setNumber("value", toCSSPrimitiveValue(*cssValue).getFloatValue());

object->setString("unit", "px");

return object.release();

}

@@ -166,7 +166,7 @@ void LayoutEditor::overlayStartedPropertyChange(const String& anchorName)

return;

}

- m_propertyInitialValue = toCSSPrimitiveValue(cssValue)->getFloatValue();

+ m_propertyInitialValue = toCSSPrimitiveValue(*cssValue).getFloatValue();

}

void LayoutEditor::overlayPropertyChanged(float cssDelta)

« no previous file with comments | « Source/core/editing/markup.cpp ('k') | Source/core/layout/svg/ReferenceFilterBuilder.cpp » ('j') | no next file with comments »