Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 1225553002: CSSValue Immediates: Make CSSPrimitiveValue a container (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleBuilderConverter.h
diff --git a/Source/core/css/resolver/StyleBuilderConverter.h b/Source/core/css/resolver/StyleBuilderConverter.h
index 3290207939e3df0becf9c77b44fbddc7a4460475..f7cbc9dba693ab0f9d572f7deadc397deee03984 100644
--- a/Source/core/css/resolver/StyleBuilderConverter.h
+++ b/Source/core/css/resolver/StyleBuilderConverter.h
@@ -125,7 +125,7 @@ T StyleBuilderConverter::convertFlags(StyleResolverState& state, CSSValue value)
template <typename T>
T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, CSSValue value)
{
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(value);
CSSValueID valueID = primitiveValue.getValueID();
if (valueID == CSSValueThin)
return 1;
@@ -151,7 +151,7 @@ T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, CSSValue va
template <CSSValueID IdForNone>
AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue value)
{
- CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(value);
if (primitiveValue.getValueID() == IdForNone)
return nullAtom;
return AtomicString(primitiveValue.getStringValue());
« no previous file with comments | « Source/core/css/resolver/FilterOperationResolver.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698