Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, philipj_slow, gavinp+prerender_chromium.org, Rik, blink-reviews-style_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, Justin Novosad, dshwang, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/html/. - We should specify just one of them to a function. - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1164 lines, -1164 lines) Patch
M Source/core/html/ClassList.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 2 chunks +25 lines, -25 lines 0 comments Download
M Source/core/html/HTMLAppletElement.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLAreaElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLAudioElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBRElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLBaseElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLBodyElement.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 4 chunks +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLContentElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDataListElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDivElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLFontElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 8 chunks +32 lines, -32 lines 0 comments Download
M Source/core/html/HTMLFormControlElementWithState.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLFrameElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLHRElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 4 chunks +31 lines, -31 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageLoader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 9 chunks +90 lines, -90 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/html/HTMLLIElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLLabelElement.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLLegendElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 6 chunks +25 lines, -25 lines 0 comments Download
M Source/core/html/HTMLMapElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 5 chunks +38 lines, -38 lines 0 comments Download
M Source/core/html/HTMLMediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMenuItemElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMetaElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLModElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLNameCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNoEmbedElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNoScriptElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOListElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 2 chunks +29 lines, -29 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLParagraphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLParamElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPictureElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 3 chunks +20 lines, -20 lines 0 comments Download
M Source/core/html/HTMLPreElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLRTElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLRubyElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +24 lines, -24 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 5 chunks +31 lines, -31 lines 0 comments Download
M Source/core/html/HTMLShadowElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSourceElement.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTableCaptionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTableColElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTemplateElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 3 chunks +42 lines, -42 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTitleElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTrackElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLUListElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLUnknownElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.h View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLWBRElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelableElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelsNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkDefaultPresentation.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/LinkManifest.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/MediaController.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaKeyEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/PluginDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/PublicURLManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/Path2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/imports/LinkImport.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 4 chunks +24 lines, -24 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLViewSourceParser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/parser/TextDocumentParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/ClearButtonElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.h View 14 chunks +39 lines, -39 lines 0 comments Download
M Source/core/html/shadow/DateTimeNumericFieldElement.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/html/shadow/DateTimeSymbolicFieldElement.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/shadow/DetailsMarkerControl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.h View 11 chunks +28 lines, -28 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MeterShadowElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/html/track/AudioTrack.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/AudioTrackList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrackContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TrackEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TrackListBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/VideoTrack.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/VideoTrackList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/track/vtt/VTTElement.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1037683002 Patch 1

Messages

Total messages: 10 (4 generated)
tkent
yosin@, would you review this please? low priority.
5 years, 5 months ago (2015-07-07 05:27:46 UTC) #2
yosin_UTC9
rs lgtm Since this is done by sed for virtual functions and grep for virtual ...
5 years, 5 months ago (2015-07-07 05:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219013005/1
5 years, 5 months ago (2015-07-07 05:54:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/69415)
5 years, 5 months ago (2015-07-07 06:48:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219013005/1
5 years, 5 months ago (2015-07-07 08:04:08 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:32:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198376

Powered by Google App Engine
This is Rietveld 408576698