Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: Source/core/html/HTMLPlugInElement.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLPictureElement.h ('k') | Source/core/html/HTMLPreElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInElement.h
diff --git a/Source/core/html/HTMLPlugInElement.h b/Source/core/html/HTMLPlugInElement.h
index dd8810fc1bbb070cf6a379dbc515f15008aac5f7..1d1a00944d66a5f630b3bc764cd9245c94c2c8db 100644
--- a/Source/core/html/HTMLPlugInElement.h
+++ b/Source/core/html/HTMLPlugInElement.h
@@ -45,10 +45,10 @@ enum PreferPlugInsForImagesOption {
class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
public:
- virtual ~HTMLPlugInElement();
+ ~HTMLPlugInElement() override;
DECLARE_VIRTUAL_TRACE();
#if ENABLE(OILPAN)
- virtual void disconnectContentFrame() override;
+ void disconnectContentFrame() override;
void shouldDisposePlugin();
#endif
@@ -86,11 +86,11 @@ protected:
HTMLPlugInElement(const QualifiedName& tagName, Document&, bool createdByParser, PreferPlugInsForImagesOption);
// Node functions:
- virtual void didMoveToNewDocument(Document& oldDocument) override;
+ void didMoveToNewDocument(Document& oldDocument) override;
// Element functions:
- virtual bool isPresentationAttribute(const QualifiedName&) const override;
- virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
+ bool isPresentationAttribute(const QualifiedName&) const override;
+ void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
virtual bool hasFallbackContent() const;
virtual bool useFallbackContent() const;
@@ -116,27 +116,27 @@ protected:
private:
// EventTarget functions:
- virtual void removeAllEventListeners() override final;
+ void removeAllEventListeners() final;
// Node functions:
- virtual bool canContainRangeEndPoint() const override { return false; }
- virtual bool willRespondToMouseClickEvents() override final;
- virtual void defaultEventHandler(Event*) override final;
- virtual void attach(const AttachContext& = AttachContext()) override final;
- virtual void detach(const AttachContext& = AttachContext()) override final;
- virtual void finishParsingChildren() override final;
+ bool canContainRangeEndPoint() const override { return false; }
+ bool willRespondToMouseClickEvents() final;
+ void defaultEventHandler(Event*) final;
+ void attach(const AttachContext& = AttachContext()) final;
+ void detach(const AttachContext& = AttachContext()) final;
+ void finishParsingChildren() final;
// Element functions:
- virtual LayoutObject* createLayoutObject(const ComputedStyle&) override;
- virtual bool supportsFocus() const override final { return true; }
- virtual bool layoutObjectIsFocusable() const override final;
- virtual bool isKeyboardFocusable() const override final;
- virtual void didAddUserAgentShadowRoot(ShadowRoot&) override final;
- virtual void willAddFirstOpenShadowRoot() override final;
+ LayoutObject* createLayoutObject(const ComputedStyle&) override;
+ bool supportsFocus() const final { return true; }
+ bool layoutObjectIsFocusable() const final;
+ bool isKeyboardFocusable() const final;
+ void didAddUserAgentShadowRoot(ShadowRoot&) final;
+ void willAddFirstOpenShadowRoot() final;
// HTMLElement function:
- virtual bool hasCustomFocusLogic() const override;
- virtual bool isPluginElement() const override final;
+ bool hasCustomFocusLogic() const override;
+ bool isPluginElement() const final;
// Return any existing LayoutPart without triggering relayout, or 0 if it
// doesn't yet exist.
« no previous file with comments | « Source/core/html/HTMLPictureElement.h ('k') | Source/core/html/HTMLPreElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698