Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: Source/core/html/track/TextTrack.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/LoadableTextTrack.h ('k') | Source/core/html/track/TextTrackContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrack.h
diff --git a/Source/core/html/track/TextTrack.h b/Source/core/html/track/TextTrack.h
index 1c890654d660710d3840cf8404a10245e07deb63..6e5e2ea3e702a07a92f2807de740f4a80598caec 100644
--- a/Source/core/html/track/TextTrack.h
+++ b/Source/core/html/track/TextTrack.h
@@ -54,12 +54,12 @@ public:
{
return adoptRefWillBeNoop(new TextTrack(kind, label, language, emptyAtom, AddTrack));
}
- virtual ~TextTrack();
+ ~TextTrack() override;
virtual void setTrackList(TextTrackList*);
TextTrackList* trackList() { return m_trackList; }
- virtual void setKind(const AtomicString&) override;
+ void setKind(const AtomicString&) override;
static const AtomicString& subtitlesKeyword();
static const AtomicString& captionsKeyword();
@@ -114,16 +114,16 @@ public:
void removeAllCues();
// EventTarget methods
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
DECLARE_VIRTUAL_TRACE();
protected:
TextTrack(const AtomicString& kind, const AtomicString& label, const AtomicString& language, const AtomicString& id, TextTrackType);
- virtual bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }
- virtual AtomicString defaultKind() const override { return subtitlesKeyword(); }
+ bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }
+ AtomicString defaultKind() const override { return subtitlesKeyword(); }
void addListOfCues(WillBeHeapVector<RefPtrWillBeMember<TextTrackCue>>&);
« no previous file with comments | « Source/core/html/track/LoadableTextTrack.h ('k') | Source/core/html/track/TextTrackContainer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698