Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: Source/core/html/HTMLElement.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLDocument.h ('k') | Source/core/html/HTMLEmbedElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLElement.h
diff --git a/Source/core/html/HTMLElement.h b/Source/core/html/HTMLElement.h
index 3041c0ee91b446f6779cd6fa532a3341de38bf0b..b218b460cda527b263734fbe231653882b0fae4c 100644
--- a/Source/core/html/HTMLElement.h
+++ b/Source/core/html/HTMLElement.h
@@ -46,8 +46,8 @@ public:
bool hasTagName(const HTMLQualifiedName& name) const { return hasLocalName(name.localName()); }
- virtual String title() const override final;
- virtual short tabIndex() const override;
+ String title() const final;
+ short tabIndex() const override;
void setInnerText(const String&, ExceptionState&);
void setOuterText(const String&, ExceptionState&);
@@ -71,7 +71,7 @@ public:
void click();
- virtual void accessKeyAction(bool sendMouseEvents) override;
+ void accessKeyAction(bool sendMouseEvents) override;
bool ieForbidsInsertHTML() const;
@@ -88,12 +88,12 @@ public:
virtual bool isLabelable() const { return false; }
// http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#interactive-content
virtual bool isInteractiveContent() const;
- virtual void defaultEventHandler(Event*) override;
+ void defaultEventHandler(Event*) override;
static const AtomicString& eventNameForAttributeName(const QualifiedName& attrName);
- virtual bool matchesReadOnlyPseudoClass() const override;
- virtual bool matchesReadWritePseudoClass() const override;
+ bool matchesReadOnlyPseudoClass() const override;
+ bool matchesReadWritePseudoClass() const override;
static const AtomicString& eventParameterName();
@@ -112,16 +112,16 @@ protected:
void applyAlignmentAttributeToStyle(const AtomicString&, MutableStylePropertySet*);
void applyBorderAttributeToStyle(const AtomicString&, MutableStylePropertySet*);
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
- virtual bool isPresentationAttribute(const QualifiedName&) const override;
- virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ bool isPresentationAttribute(const QualifiedName&) const override;
+ void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
unsigned parseBorderWidthAttribute(const AtomicString&) const;
- virtual void childrenChanged(const ChildrenChange&) override;
+ void childrenChanged(const ChildrenChange&) override;
void calculateAndAdjustDirectionality();
private:
- virtual String nodeName() const override final;
+ String nodeName() const final;
bool isHTMLElement() const = delete; // This will catch anyone doing an unnecessary check.
bool isStyledElement() const = delete; // This will catch anyone doing an unnecessary check.
« no previous file with comments | « Source/core/html/HTMLDocument.h ('k') | Source/core/html/HTMLEmbedElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698