Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/shadow/DateTimeFieldElements.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/DateTimeFieldElement.h ('k') | Source/core/html/shadow/DateTimeNumericFieldElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/DateTimeFieldElements.h
diff --git a/Source/core/html/shadow/DateTimeFieldElements.h b/Source/core/html/shadow/DateTimeFieldElements.h
index 6685cfd34aad0afe811191fa2dac0311fa9f77ca..9a6b325f095c9c0457e330d55522ac6a415d5a6e 100644
--- a/Source/core/html/shadow/DateTimeFieldElements.h
+++ b/Source/core/html/shadow/DateTimeFieldElements.h
@@ -42,9 +42,9 @@ private:
DateTimeAMPMFieldElement(Document&, FieldOwner&, const Vector<String>&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeDayFieldElement final : public DateTimeNumericFieldElement {
@@ -57,9 +57,9 @@ private:
DateTimeDayFieldElement(Document&, FieldOwner&, const String& placeholder, const Range&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeHourFieldElementBase : public DateTimeNumericFieldElement {
@@ -71,8 +71,8 @@ protected:
private:
// DateTimeFieldElement functions.
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeHour11FieldElement final : public DateTimeHourFieldElementBase {
@@ -85,8 +85,8 @@ private:
DateTimeHour11FieldElement(Document&, FieldOwner&, const Range& hour23Range, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
};
class DateTimeHour12FieldElement final : public DateTimeHourFieldElementBase {
@@ -99,8 +99,8 @@ private:
DateTimeHour12FieldElement(Document&, FieldOwner&, const Range& hour23Range, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
};
class DateTimeHour23FieldElement final : public DateTimeHourFieldElementBase {
@@ -113,8 +113,8 @@ private:
DateTimeHour23FieldElement(Document&, FieldOwner&, const Range& hour23Range, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
};
class DateTimeHour24FieldElement final : public DateTimeHourFieldElementBase {
@@ -127,8 +127,8 @@ private:
DateTimeHour24FieldElement(Document&, FieldOwner&, const Range& hour23Range, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsInteger(int, EventBehavior = DispatchNoEvent) override;
};
class DateTimeMillisecondFieldElement final : public DateTimeNumericFieldElement {
@@ -141,9 +141,9 @@ private:
DateTimeMillisecondFieldElement(Document&, FieldOwner&, const Range&, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeMinuteFieldElement final : public DateTimeNumericFieldElement {
@@ -156,9 +156,9 @@ private:
DateTimeMinuteFieldElement(Document&, FieldOwner&, const Range&, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeMonthFieldElement final : public DateTimeNumericFieldElement {
@@ -171,9 +171,9 @@ private:
DateTimeMonthFieldElement(Document&, FieldOwner&, const String& placeholder, const Range&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeSecondFieldElement final : public DateTimeNumericFieldElement {
@@ -186,9 +186,9 @@ private:
DateTimeSecondFieldElement(Document&, FieldOwner&, const Range&, const Step&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeSymbolicMonthFieldElement final : public DateTimeSymbolicFieldElement {
@@ -201,9 +201,9 @@ private:
DateTimeSymbolicMonthFieldElement(Document&, FieldOwner&, const Vector<String>&, int minimum, int maximum);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeWeekFieldElement final : public DateTimeNumericFieldElement {
@@ -216,9 +216,9 @@ private:
DateTimeWeekFieldElement(Document&, FieldOwner&, const Range&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
};
class DateTimeYearFieldElement final : public DateTimeNumericFieldElement {
@@ -247,13 +247,13 @@ private:
DateTimeYearFieldElement(Document&, FieldOwner&, const Parameters&);
// DateTimeFieldElement functions.
- virtual void populateDateTimeFieldsState(DateTimeFieldsState&) override;
- virtual void setValueAsDate(const DateComponents&) override;
- virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
+ void populateDateTimeFieldsState(DateTimeFieldsState&) override;
+ void setValueAsDate(const DateComponents&) override;
+ void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) override;
// DateTimeNumericFieldElement functions.
- virtual int defaultValueForStepDown() const override;
- virtual int defaultValueForStepUp() const override;
+ int defaultValueForStepDown() const override;
+ int defaultValueForStepUp() const override;
bool m_minIsSpecified;
bool m_maxIsSpecified;
« no previous file with comments | « Source/core/html/shadow/DateTimeFieldElement.h ('k') | Source/core/html/shadow/DateTimeNumericFieldElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698