Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: Source/core/html/parser/HTMLDocumentParser.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/imports/LinkImport.h ('k') | Source/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/HTMLDocumentParser.h
diff --git a/Source/core/html/parser/HTMLDocumentParser.h b/Source/core/html/parser/HTMLDocumentParser.h
index 756aa315aebc869a84f9d07fa2e4ed0528bc4203..cdd5f0c3de9e66de846d8d1ea52ae6dc7947c763 100644
--- a/Source/core/html/parser/HTMLDocumentParser.h
+++ b/Source/core/html/parser/HTMLDocumentParser.h
@@ -74,7 +74,7 @@ public:
{
return adoptRefWillBeNoop(new HTMLDocumentParser(document, reportErrors, backgroundParsingPolicy));
}
- virtual ~HTMLDocumentParser();
+ ~HTMLDocumentParser() override;
DECLARE_VIRTUAL_TRACE();
// Exposed for HTMLParserScheduler
@@ -84,12 +84,12 @@ public:
HTMLTokenizer* tokenizer() const { return m_tokenizer.get(); }
- virtual TextPosition textPosition() const override final;
- virtual bool isParsingAtLineNumber() const override final;
- virtual OrdinalNumber lineNumber() const override final;
+ TextPosition textPosition() const final;
+ bool isParsingAtLineNumber() const final;
+ OrdinalNumber lineNumber() const final;
- virtual void suspendScheduledTasks() override final;
- virtual void resumeScheduledTasks() override final;
+ void suspendScheduledTasks() final;
+ void resumeScheduledTasks() final;
struct ParsedChunk {
OwnPtr<CompactHTMLTokenStream> tokens;
@@ -104,16 +104,16 @@ public:
void didReceiveParsedChunkFromBackgroundParser(PassOwnPtr<ParsedChunk>);
void didReceiveEncodingDataFromBackgroundParser(const DocumentEncodingData&);
- virtual void appendBytes(const char* bytes, size_t length) override;
- virtual void flush() override final;
- virtual void setDecoder(PassOwnPtr<TextResourceDecoder>) override final;
+ void appendBytes(const char* bytes, size_t length) override;
+ void flush() final;
+ void setDecoder(PassOwnPtr<TextResourceDecoder>) final;
UseCounter* useCounter() { return UseCounter::getFrom(contextForParsingSession()); }
protected:
- virtual void insert(const SegmentedString&) override final;
- virtual void append(const String&) override;
- virtual void finish() override final;
+ void insert(const SegmentedString&) final;
+ void append(const String&) override;
+ void finish() final;
HTMLDocumentParser(HTMLDocument&, bool reportErrors, ParserSynchronizationPolicy);
HTMLDocumentParser(DocumentFragment*, Element* contextElement, ParserContentPolicy);
@@ -129,20 +129,20 @@ private:
}
// DocumentParser
- virtual void detach() override final;
- virtual bool hasInsertionPoint() override final;
- virtual bool processingData() const override final;
- virtual void prepareToStopParsing() override final;
- virtual void stopParsing() override final;
- virtual bool isWaitingForScripts() const override final;
- virtual bool isExecutingScript() const override final;
- virtual void executeScriptsWaitingForResources() override final;
+ void detach() final;
+ bool hasInsertionPoint() final;
+ bool processingData() const final;
+ void prepareToStopParsing() final;
+ void stopParsing() final;
+ bool isWaitingForScripts() const final;
+ bool isExecutingScript() const final;
+ void executeScriptsWaitingForResources() final;
// HTMLScriptRunnerHost
- virtual void notifyScriptLoaded(Resource*) override final;
- virtual HTMLInputStream& inputStream() override final { return m_input; }
- virtual bool hasPreloadScanner() const override final { return m_preloadScanner.get() && !shouldUseThreading(); }
- virtual void appendCurrentInputStreamToPreloadScannerAndScan() override final;
+ void notifyScriptLoaded(Resource*) final;
+ HTMLInputStream& inputStream() final { return m_input; }
+ bool hasPreloadScanner() const final { return m_preloadScanner.get() && !shouldUseThreading(); }
+ void appendCurrentInputStreamToPreloadScannerAndScan() final;
void startBackgroundParser();
void stopBackgroundParser();
« no previous file with comments | « Source/core/html/imports/LinkImport.h ('k') | Source/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698