Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLKeygenElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 77
78 namespace blink { 78 namespace blink {
79 79
80 using namespace HTMLNames; 80 using namespace HTMLNames;
81 81
82 class ListAttributeTargetObserver : public IdTargetObserver { 82 class ListAttributeTargetObserver : public IdTargetObserver {
83 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(ListAttributeTargetObserver); 83 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(ListAttributeTargetObserver);
84 public: 84 public:
85 static PassOwnPtrWillBeRawPtr<ListAttributeTargetObserver> create(const Atom icString& id, HTMLInputElement*); 85 static PassOwnPtrWillBeRawPtr<ListAttributeTargetObserver> create(const Atom icString& id, HTMLInputElement*);
86 DECLARE_VIRTUAL_TRACE(); 86 DECLARE_VIRTUAL_TRACE();
87 virtual void idTargetChanged() override; 87 void idTargetChanged() override;
88 88
89 private: 89 private:
90 ListAttributeTargetObserver(const AtomicString& id, HTMLInputElement*); 90 ListAttributeTargetObserver(const AtomicString& id, HTMLInputElement*);
91 91
92 RawPtrWillBeMember<HTMLInputElement> m_element; 92 RawPtrWillBeMember<HTMLInputElement> m_element;
93 }; 93 };
94 94
95 // FIXME: According to HTML4, the length attribute's value can be arbitrarily 95 // FIXME: According to HTML4, the length attribute's value can be arbitrarily
96 // large. However, due to https://bugs.webkit.org/show_bug.cgi?id=14536 things 96 // large. However, due to https://bugs.webkit.org/show_bug.cgi?id=14536 things
97 // get rather sluggish when a text field has a larger number of characters than 97 // get rather sluggish when a text field has a larger number of characters than
(...skipping 1827 matching lines...) Expand 10 before | Expand all | Expand 10 after
1925 void HTMLInputElement::ensurePrimaryContent() 1925 void HTMLInputElement::ensurePrimaryContent()
1926 { 1926 {
1927 m_inputTypeView->ensurePrimaryContent(); 1927 m_inputTypeView->ensurePrimaryContent();
1928 } 1928 }
1929 1929
1930 bool HTMLInputElement::hasFallbackContent() const 1930 bool HTMLInputElement::hasFallbackContent() const
1931 { 1931 {
1932 return m_inputTypeView->hasFallbackContent(); 1932 return m_inputTypeView->hasFallbackContent();
1933 } 1933 }
1934 } // namespace 1934 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLKeygenElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698