Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: Source/core/html/HTMLFormControlsCollection.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElementWithState.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlsCollection.h
diff --git a/Source/core/html/HTMLFormControlsCollection.h b/Source/core/html/HTMLFormControlsCollection.h
index 7c5bb74f5acdc955caaefaccd41cbff912de634a..eedb4143bbdba5e0744d5c05b0e359b8446573fb 100644
--- a/Source/core/html/HTMLFormControlsCollection.h
+++ b/Source/core/html/HTMLFormControlsCollection.h
@@ -42,11 +42,11 @@ class HTMLFormControlsCollection final : public HTMLCollection {
public:
static PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> create(ContainerNode&, CollectionType);
- virtual ~HTMLFormControlsCollection();
+ ~HTMLFormControlsCollection() override;
HTMLElement* item(unsigned offset) const { return toHTMLElement(HTMLCollection::item(offset)); }
- virtual HTMLElement* namedItem(const AtomicString& name) const override;
+ HTMLElement* namedItem(const AtomicString& name) const override;
void namedGetter(const AtomicString& name, RadioNodeListOrElement&);
DECLARE_VIRTUAL_TRACE();
@@ -54,13 +54,13 @@ public:
private:
explicit HTMLFormControlsCollection(ContainerNode&);
- virtual void updateIdNameCache() const override;
- virtual void supportedPropertyNames(Vector<String>& names) override;
+ void updateIdNameCache() const override;
+ void supportedPropertyNames(Vector<String>& names) override;
const FormAssociatedElement::List& formControlElements() const;
const WillBeHeapVector<RawPtrWillBeMember<HTMLImageElement>>& formImageElements() const;
- virtual HTMLElement* virtualItemAfter(Element*) const override;
- virtual void invalidateCache(Document* oldDocument = 0) const override;
+ HTMLElement* virtualItemAfter(Element*) const override;
+ void invalidateCache(Document* oldDocument = 0) const override;
mutable RawPtrWillBeMember<HTMLElement> m_cachedElement;
mutable unsigned m_cachedElementOffsetInArray;
« no previous file with comments | « Source/core/html/HTMLFormControlElementWithState.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698