Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLFrameElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index 0b58056170bc14070f69b47fdd59e91723600455..b00481b1090eafd816532280b1e42e8c7bb824a9 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -46,7 +46,7 @@ class CORE_EXPORT HTMLFormElement final : public HTMLElement {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<HTMLFormElement> create(Document&);
- virtual ~HTMLFormElement();
+ ~HTMLFormElement() override;
DECLARE_VIRTUAL_TRACE();
PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> elements();
@@ -95,8 +95,8 @@ public:
bool checkValidity();
bool reportValidity();
- virtual bool matchesValidityPseudoClasses() const override final;
- virtual bool isValidElement() override final;
+ bool matchesValidityPseudoClasses() const final;
+ bool isValidElement() final;
enum AutocompleteResult {
AutocompleteResultSuccess,
@@ -121,21 +121,21 @@ public:
private:
explicit HTMLFormElement(Document&);
- virtual bool layoutObjectIsNeeded(const ComputedStyle&) override;
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
- virtual void removedFrom(ContainerNode*) override;
- virtual void finishParsingChildren() override;
+ bool layoutObjectIsNeeded(const ComputedStyle&) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ void removedFrom(ContainerNode*) override;
+ void finishParsingChildren() override;
- virtual void handleLocalEvents(Event&) override;
+ void handleLocalEvents(Event&) override;
- virtual void attributeWillChange(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue) override;
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
- virtual bool isURLAttribute(const Attribute&) const override;
- virtual bool hasLegalLinkAttribute(const QualifiedName&) const override;
+ void attributeWillChange(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue) override;
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ bool isURLAttribute(const Attribute&) const override;
+ bool hasLegalLinkAttribute(const QualifiedName&) const override;
- virtual bool shouldRegisterAsNamedItem() const override { return true; }
+ bool shouldRegisterAsNamedItem() const override { return true; }
- virtual void copyNonAttributePropertiesFromElement(const Element&) override;
+ void copyNonAttributePropertiesFromElement(const Element&) override;
void submitDialog(PassRefPtrWillBeRawPtr<FormSubmission>);
void submit(Event*, bool activateSubmitButton, bool processingUserGesture);
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLFrameElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698