Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: Source/core/html/HTMLTextFormControlElement.h

Issue 1219013005: Fix virtual/override/final usage in Source/core/html/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextFormControlElement.h
diff --git a/Source/core/html/HTMLTextFormControlElement.h b/Source/core/html/HTMLTextFormControlElement.h
index 95a131ba743bec1388816d5baa6c1f9f98f3ca42..cf1b22f14632670f7bc3a6b498c422c85978023b 100644
--- a/Source/core/html/HTMLTextFormControlElement.h
+++ b/Source/core/html/HTMLTextFormControlElement.h
@@ -52,12 +52,12 @@ public:
NotChangeSelection
};
- virtual ~HTMLTextFormControlElement();
+ ~HTMLTextFormControlElement() override;
void forwardEvent(Event*);
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
// The derived class should return true if placeholder processing is needed.
virtual bool supportsPlaceholder() const = 0;
@@ -86,7 +86,7 @@ public:
const AtomicString& autocapitalize() const;
void setAutocapitalize(const AtomicString&);
- virtual void dispatchFormControlChangeEvent() override final;
+ void dispatchFormControlChangeEvent() final;
virtual String value() const = 0;
@@ -114,7 +114,7 @@ protected:
bool isPlaceholderEmpty() const;
virtual void updatePlaceholderText() = 0;
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
void cacheSelection(int start, int end, TextFieldSelectionDirection direction)
{
@@ -126,7 +126,7 @@ protected:
void restoreCachedSelection();
- virtual void defaultEventHandler(Event*) override;
+ void defaultEventHandler(Event*) override;
virtual void subtreeHasChanged() = 0;
void setLastChangeWasNotUserEdit() { m_lastChangeWasUserEdit = false; }
@@ -134,15 +134,15 @@ protected:
String valueWithHardLineBreaks() const;
virtual bool shouldDispatchFormControlChangeEvent(String&, String&);
- virtual void copyNonAttributePropertiesFromElement(const Element&) override;
+ void copyNonAttributePropertiesFromElement(const Element&) override;
private:
int computeSelectionStart() const;
int computeSelectionEnd() const;
TextFieldSelectionDirection computeSelectionDirection() const;
- virtual void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType) override final;
- virtual void dispatchBlurEvent(Element* newFocusedElement, WebFocusType) override final;
+ void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType) final;
+ void dispatchBlurEvent(Element* newFocusedElement, WebFocusType) final;
void scheduleSelectEvent();
// Returns true if user-editable value is empty. Used to check placeholder visibility.
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698