Cosmetic changes to tests to make it easier to concatenate them.

Cosmetic changes to tests to make it easier to concatenate them.

When compiling on a laptop I like to concatenate the small test files.
This makes a big difference to compile times. These changes make that
easier.

R=ulan@chromium.org
BUG=

Committed: https://crrev.com/4f5337a2b64dc2486bde7b6b2c52ad6b1fedeaa0
Cr-Commit-Position: refs/heads/master@{#28742}

[ulan, 2015-06-01 13:08:24]

Hi Erik,

I think more scalable and cleaner approach would be to make the concatenation
script to insert all these changes locally. That approach will continue to work
for new test files in contrast to manual edits.

https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):

https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task...
src/background-parsing-task.cc:75: }  // namespace v8
Other files (e.g. src/allocation.cc) now have "} }  // namespace v8::internal"
Maybe do the same here? Or change the other files.

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-g...
File test/cctest/compiler/test-graph-visualizer.cc (right):

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-g...
test/cctest/compiler/test-graph-visualizer.cc:20: namespace
test_graph_visualizer {
Now some tests are namespaced and others are not.

I think this should be done in concatenation script: insert "namespace
${test-file} {" before "using namespace v8::internal;".

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-o...
File test/cctest/compiler/test-operator.cc (right):

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-o...
test/cctest/compiler/test-operator.cc:286: #undef FOLD
This should be done in concatenation script.

[Erik Corry, 2015-06-01 15:15:46]

erik.corry@gmail.com changed reviewers:
+ erik.corry@gmail.com

[Erik Corry, 2015-06-01 15:15:47]

https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):

https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task...
src/background-parsing-task.cc:75: }  // namespace v8
On 2015/06/01 13:08:24, ulan wrote:
> Other files (e.g. src/allocation.cc) now have "} }  // namespace v8::internal"
> Maybe do the same here? Or change the other files.

I've now done this.  It's made the CL a bit unwieldy.

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-g...
File test/cctest/compiler/test-graph-visualizer.cc (right):

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-g...
test/cctest/compiler/test-graph-visualizer.cc:20: namespace
test_graph_visualizer {
On 2015/06/01 13:08:24, ulan wrote:
> Now some tests are namespaced and others are not.
> 
> I think this should be done in concatenation script: insert "namespace
> ${test-file} {" before "using namespace v8::internal;".

test namespaces removed

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-o...
File test/cctest/compiler/test-operator.cc (right):

https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-o...
test/cctest/compiler/test-operator.cc:286: #undef FOLD
On 2015/06/01 13:08:24, ulan wrote:
> This should be done in concatenation script. 

Done

[ulan, 2015-06-01 15:52:40]

wow, lgtm.

After you removed the wrapping of tests and undefs, does this CL still help with
concatenation?

[Erik Corry, 2015-06-01 16:17:46]

On 2015/06/01 15:52:40, ulan wrote:
> wow, lgtm.
> 
> After you removed the wrapping of tests and undefs, does this CL still help
with
> concatenation?

For now I will just not concatenate the affected files.  It's quite hard to
automate namespace stuff.  One unexpected thing I found was that this fails:

namespace a {
  void foo();
}

namespace b {
  void foo();
}

namespace {
  using namespace a;
}

using namespace b;

foo(); // This is ambiguous because both 'using' declarations are still in
effect!

[Erik Corry Chromium.org, 2015-06-01 16:20:34]

The CQ bit was checked by erikcorry@chromium.org

[commit-bot: I haz the power, 2015-06-01 16:20:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163803002/80001

[commit-bot: I haz the power, 2015-06-01 16:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 16:42:08]

Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Erik Corry Chromium.org, 2015-06-01 19:17:49]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-01 19:18:14]

The CQ bit was unchecked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-01 19:19:04]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-01 19:19:06]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1163803002/#ps100001
(title: "Fix snapshot-external.cc")

[commit-bot: I haz the power, 2015-06-01 19:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163803002/100001

[commit-bot: I haz the power, 2015-06-01 22:47:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-01 22:47:22]

Patchset 6 (id:??) landed as
https://crrev.com/4f5337a2b64dc2486bde7b6b2c52ad6b1fedeaa0
Cr-Commit-Position: refs/heads/master@{#28742}