Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: test/cctest/test-global-object.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix snapshot-external.cc Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-hydrogen-types.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11 matching lines...) Expand all
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "src/v8.h" 28 #include "src/v8.h"
29 29
30 #include "test/cctest/cctest.h" 30 #include "test/cctest/cctest.h"
31 31
32 using namespace v8;
33
34 // This test fails if properties on the prototype of the global object appear 32 // This test fails if properties on the prototype of the global object appear
35 // as declared globals. 33 // as declared globals.
36 TEST(StrictUndeclaredGlobalVariable) { 34 TEST(StrictUndeclaredGlobalVariable) {
37 HandleScope scope(CcTest::isolate()); 35 v8::HandleScope scope(CcTest::isolate());
38 v8::Local<v8::String> var_name = v8_str("x"); 36 v8::Local<v8::String> var_name = v8_str("x");
39 LocalContext context; 37 LocalContext context;
40 v8::TryCatch try_catch(CcTest::isolate()); 38 v8::TryCatch try_catch(CcTest::isolate());
41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;"); 39 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");
42 v8::Handle<v8::Object> proto = v8::Object::New(CcTest::isolate()); 40 v8::Handle<v8::Object> proto = v8::Object::New(CcTest::isolate());
43 v8::Handle<v8::Object> global = 41 v8::Handle<v8::Object> global =
44 context->Global()->GetPrototype().As<v8::Object>(); 42 context->Global()->GetPrototype().As<v8::Object>();
45 proto->Set(var_name, v8_num(100)); 43 proto->Set(var_name, v8_num(100));
46 global->SetPrototype(proto); 44 global->SetPrototype(proto);
47 script->Run(); 45 script->Run();
48 CHECK(try_catch.HasCaught()); 46 CHECK(try_catch.HasCaught());
49 v8::String::Utf8Value exception(try_catch.Exception()); 47 v8::String::Utf8Value exception(try_catch.Exception());
50 CHECK_EQ(0, strcmp("ReferenceError: x is not defined", *exception)); 48 CHECK_EQ(0, strcmp("ReferenceError: x is not defined", *exception));
51 } 49 }
OLDNEW
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-hydrogen-types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698