Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: test/cctest/test-weakmaps.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix snapshot-external.cc Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-version.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 16 matching lines...) Expand all
27 27
28 #include <utility> 28 #include <utility>
29 29
30 #include "src/v8.h" 30 #include "src/v8.h"
31 31
32 #include "src/global-handles.h" 32 #include "src/global-handles.h"
33 #include "test/cctest/cctest.h" 33 #include "test/cctest/cctest.h"
34 34
35 using namespace v8::internal; 35 using namespace v8::internal;
36 36
37
38 static Isolate* GetIsolateFrom(LocalContext* context) { 37 static Isolate* GetIsolateFrom(LocalContext* context) {
39 return reinterpret_cast<Isolate*>((*context)->GetIsolate()); 38 return reinterpret_cast<Isolate*>((*context)->GetIsolate());
40 } 39 }
41 40
42 41
43 static Handle<JSWeakMap> AllocateJSWeakMap(Isolate* isolate) { 42 static Handle<JSWeakMap> AllocateJSWeakMap(Isolate* isolate) {
44 Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap(); 43 Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
45 // Do not leak handles for the hash table, it would make entries strong. 44 // Do not leak handles for the hash table, it would make entries strong.
46 { 45 {
47 HandleScope scope(isolate); 46 HandleScope scope(isolate);
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 { 259 {
261 HandleScope scope(isolate); 260 HandleScope scope(isolate);
262 AllocateJSWeakMap(isolate); 261 AllocateJSWeakMap(isolate);
263 SimulateIncrementalMarking(heap); 262 SimulateIncrementalMarking(heap);
264 } 263 }
265 // The weak map is marked black here but leaving the handle scope will make 264 // The weak map is marked black here but leaving the handle scope will make
266 // the object unreachable. Aborting incremental marking will clear all the 265 // the object unreachable. Aborting incremental marking will clear all the
267 // marking bits which makes the weak map garbage. 266 // marking bits which makes the weak map garbage.
268 heap->CollectAllGarbage(); 267 heap->CollectAllGarbage();
269 } 268 }
OLDNEW
« no previous file with comments | « test/cctest/test-version.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698