Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: test/cctest/test-threads.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix snapshot-external.cc Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-spaces.cc ('k') | test/cctest/test-version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-threads.cc
diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc
index e192bc155941d8f617bca42afa50b1cfb9ed90a7..5f2cdae2a2488a2931c50eee50c54933e8f47042 100644
--- a/test/cctest/test-threads.cc
+++ b/test/cctest/test-threads.cc
@@ -32,12 +32,7 @@
#include "src/isolate.h"
-enum Turn {
- FILL_CACHE,
- CLEAN_CACHE,
- SECOND_TIME_FILL_CACHE,
- DONE
-};
+enum Turn { FILL_CACHE, CLEAN_CACHE, SECOND_TIME_FILL_CACHE, CACHE_DONE };
static Turn turn = FILL_CACHE;
@@ -76,7 +71,7 @@ class ThreadA : public v8::base::Thread {
// Rerun the script.
CHECK(script->Run()->IsTrue());
- turn = DONE;
+ turn = CACHE_DONE;
}
};
@@ -116,7 +111,7 @@ TEST(JSFunctionResultCachesInTwoThreads) {
threadA.Join();
threadB.Join();
- CHECK_EQ(DONE, turn);
+ CHECK_EQ(CACHE_DONE, turn);
}
class ThreadIdValidationThread : public v8::base::Thread {
« no previous file with comments | « test/cctest/test-spaces.cc ('k') | test/cctest/test-version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698