Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: src/string-builder.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix snapshot-external.cc Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/snapshot/snapshot-source-sink.cc ('k') | src/string-search.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/string-builder.h" 5 #include "src/string-builder.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 namespace internal { 8 namespace internal {
9 9
10 MaybeHandle<String> ReplacementStringBuilder::ToString() { 10 MaybeHandle<String> ReplacementStringBuilder::ToString() {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 101
102 void IncrementalStringBuilder::AppendString(Handle<String> string) { 102 void IncrementalStringBuilder::AppendString(Handle<String> string) {
103 ShrinkCurrentPart(); 103 ShrinkCurrentPart();
104 part_length_ = kInitialPartLength; // Allocate conservatively. 104 part_length_ = kInitialPartLength; // Allocate conservatively.
105 Extend(); // Attach current part and allocate new part. 105 Extend(); // Attach current part and allocate new part.
106 Handle<String> concat = 106 Handle<String> concat =
107 factory()->NewConsString(accumulator(), string).ToHandleChecked(); 107 factory()->NewConsString(accumulator(), string).ToHandleChecked();
108 set_accumulator(concat); 108 set_accumulator(concat);
109 } 109 }
110 } 110 } // namespace internal
111 } // namespace v8::internal 111 } // namespace v8
OLDNEW
« no previous file with comments | « src/snapshot/snapshot-source-sink.cc ('k') | src/string-search.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698