Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: src/extensions/externalize-string-extension.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix snapshot-external.cc Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/execution.cc ('k') | src/extensions/free-buffer-extension.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/extensions/externalize-string-extension.h" 5 #include "src/extensions/externalize-string-extension.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 namespace internal { 8 namespace internal {
9 9
10 template <typename Char, typename Base> 10 template <typename Char, typename Base>
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 args.GetIsolate()->ThrowException(v8::String::NewFromUtf8( 115 args.GetIsolate()->ThrowException(v8::String::NewFromUtf8(
116 args.GetIsolate(), 116 args.GetIsolate(),
117 "isOneByteString() requires a single string argument.")); 117 "isOneByteString() requires a single string argument."));
118 return; 118 return;
119 } 119 }
120 bool is_one_byte = 120 bool is_one_byte =
121 Utils::OpenHandle(*args[0].As<v8::String>())->IsOneByteRepresentation(); 121 Utils::OpenHandle(*args[0].As<v8::String>())->IsOneByteRepresentation();
122 args.GetReturnValue().Set(is_one_byte); 122 args.GetReturnValue().Set(is_one_byte);
123 } 123 }
124 124
125 } } // namespace v8::internal 125 } // namespace internal
126 } // namespace v8
OLDNEW
« no previous file with comments | « src/execution.cc ('k') | src/extensions/free-buffer-extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698