|
Omnibox - Strip Extra Whitespace from Custom Search Engine Names
Whitespace in the form of tabs and line feeds and the like can screw
things up.
This fixes the fresh.amazon.com bug. (I tested it interatively.)
By the way, there is no need to do a migration pass.
The data will be correctly loaded when read from the
database. (I checked.) While it's true the database
will be out of date until written again, given that
the actual data used is correct, I don't think that's
an issue.
TBR=rdevlin.cronin,isherman,lazyboy,pvalenzuela,kmadhusu,avi
rdevlin.cronin - this trivial template URL data API change required some changes in chrome/browser/extensions
isherman - this trivial template URL data API change required some changes in chrome/browser/importer
lazyboy - this trivial template URL data API change required some changes in chrome/browser/renderer_context_menu
pvalenzuela - this trivial template URL data API change required some changes in chrome/browser/sync/test/integration
kmadhusu - this trivial template URL data API change required some changes in chrome/browser/ui/search/
avi - this trivial template URL data API change required some changes in chrome/browser/ui/cocoa/browser/
BUG= 485357
Committed: https://crrev.com/3c6d7afbb243889bc593c69085302d460a706bdb
Cr-Commit-Position: refs/heads/master@{#329742}
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+168 lines, -106 lines) |
Patch |
 |
M |
chrome/browser/autocomplete/autocomplete_provider_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
6 chunks |
+7 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_quick_provider_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_url_provider_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/search_provider_unittest.cc
|
View
|
1
2
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/shortcuts_backend_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chrome_content_browser_client_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/search_engines_private/search_engines_private_api.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/importer/in_process_importer_bridge.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/renderer_context_menu/render_view_context_menu.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search/instant_service_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search/instant_unittest_base.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search/search_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search_engines/default_search_pref_migration.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search_engines/default_search_pref_migration_unittest.cc
|
View
|
1
2
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/search_engines/search_provider_install_data_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/search_engines_helper.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
|
View
|
1
2
3
4
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search/instant_test_utils.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search/search_ipc_router_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search_engines/search_engine_tab_helper.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/search_engines/template_url_table_model.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/omnibox/autocomplete_result_unittest.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/omnibox/keyword_provider_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/default_search_manager.cc
|
View
|
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/default_search_manager_unittest.cc
|
View
|
1
2
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/keyword_table.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/keyword_table_unittest.cc
|
View
|
1
2
|
7 chunks |
+37 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_data.h
|
View
|
1
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_data.cc
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_fetcher_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_parser.cc
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_prepopulate_data.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_prepopulate_data_unittest.cc
|
View
|
1
2
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_service.cc
|
View
|
1
2
3
4
5
6
7
8
|
6 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_service_sync_unittest.cc
|
View
|
1
2
|
10 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_service_unittest.cc
|
View
|
1
2
|
16 chunks |
+16 lines, -16 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/util.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 26 (11 generated)
|