Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Whitespace in the form of tabs and line feeds and the like can screw
things up.

This fixes the fresh.amazon.com bug.  (I tested it interatively.)

By the way, there is no need to do a migration pass.
The data will be correctly loaded when read from the
database.  (I checked.)  While it's true the database
will be out of date until written again, given that
the actual data used is correct, I don't think that's
an issue.

TBR=rdevlin.cronin,isherman,lazyboy,pvalenzuela,kmadhusu,avi
rdevlin.cronin - this trivial template URL data API change required some changes in chrome/browser/extensions
isherman - this trivial template URL data API change required some changes in chrome/browser/importer
lazyboy - this trivial template URL data API change required some changes in chrome/browser/renderer_context_menu
pvalenzuela - this trivial template URL data API change required some changes in chrome/browser/sync/test/integration
kmadhusu - this trivial template URL data API change required some changes in chrome/browser/ui/search/
avi - this trivial template URL data API change required some changes in chrome/browser/ui/cocoa/browser/

BUG=485357
Committed: https://crrev.com/3c6d7afbb243889bc593c69085302d460a706bdb
Cr-Commit-Position: refs/heads/master@{#329742}

[Mark P, 2015-05-11 23:46:26]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2015-05-11 23:48:35]

This is a pretty trivial change to template_url_data.{h,cc}.  It's an API change
though so it happens to touch a lot of files.

Please take a look.

--mark

[Peter Kasting, 2015-05-11 23:53:17]

LGTM

https://codereview.chromium.org/1135163002/diff/1/components/search_engines/t...
File components/search_engines/template_url_data.h (right):

https://codereview.chromium.org/1135163002/diff/1/components/search_engines/t...
components/search_engines/template_url_data.h:26: void SetShortName(const
base::string16& shortname);
Nit: Call the arg |short_name|

[tfarina, 2015-05-12 00:00:37]

Could you remove "If this change looks good, I'll revise all the tests so they
compile and
also add a trivial unit test for this" from the CL description before landing?

[Mark P, 2015-05-12 04:37:38]

Also revised changelist description.

--mark

https://codereview.chromium.org/1135163002/diff/1/components/search_engines/t...
File components/search_engines/template_url_data.h (right):

https://codereview.chromium.org/1135163002/diff/1/components/search_engines/t...
components/search_engines/template_url_data.h:26: void SetShortName(const
base::string16& shortname);
On 2015/05/11 23:53:17, Peter Kasting wrote:
> Nit: Call the arg |short_name|

Done.

[Mark P, 2015-05-12 21:26:16]

Added a unit test in components/omnibox/keyword_provider_unittest.cc.

Made all other tests compile.

Re-review if you feel like.  Otherwise I'll submit with TBRing the appropriate
people for the template URL data API change tomorrow.

--mark

[Peter Kasting, 2015-05-12 21:30:21]

LGTM

[Mark P, 2015-05-12 23:52:54]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2015-05-12 23:53:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135163002/40001

[commit-bot: I haz the power, 2015-05-13 00:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 00:14:04]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark P, 2015-05-13 00:41:05]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2015-05-13 00:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1135163002/#ps80001
(title: "fix more compile errors")

[commit-bot: I haz the power, 2015-05-13 00:43:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135163002/80001

[commit-bot: I haz the power, 2015-05-13 01:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 01:18:54]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark P, 2015-05-13 03:54:00]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2015-05-13 03:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1135163002/#ps100001
(title: "fix mac compile error")

[commit-bot: I haz the power, 2015-05-13 03:54:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135163002/100001

[commit-bot: I haz the power, 2015-05-13 04:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 04:40:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark P, 2015-05-13 22:46:32]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2015-05-13 22:46:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1135163002/#ps200001
(title: "fix more tests that don't set short_name")

[commit-bot: I haz the power, 2015-05-13 22:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135163002/200001

[commit-bot: I haz the power, 2015-05-14 00:00:05]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-05-14 00:01:03]

Patchset 11 (id:??) landed as
https://crrev.com/3c6d7afbb243889bc593c69085302d460a706bdb
Cr-Commit-Position: refs/heads/master@{#329742}