chrome/browser/ui/search/instant_search_prerenderer_unittest.cc - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

diff --git a/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc b/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

index a347a392163ff563869777753751a52248ba62bb..23ffae6731f8db065cba17858dcd885b89771442 100644

--- a/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

+++ b/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

@@ -320,7 +320,7 @@ TEST_F(InstantSearchPrerendererTest, PrerenderingAllowed) {

// Do not allow prerendering for custom search provider requests.

TemplateURLData data;

data.SetURL("https://www.dummyurl.com/search?q=%s&img=1");

- data.short_name = ASCIIToUTF16("t");

+ data.SetShortName(ASCIIToUTF16("t"));

data.SetKeyword(ASCIIToUTF16("k"));

TemplateURL* t_url = new TemplateURL(data);

TemplateURLService* service =

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/search/instant_test_utils.cc » ('j') | no next file with comments »