Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/search_engines/default_search_pref_migration.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/search_engines/default_search_pref_migration.h" 5 #include "chrome/browser/search_engines/default_search_pref_migration.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 24 matching lines...) Expand all
35 return scoped_ptr<TemplateURLData>(); 35 return scoped_ptr<TemplateURLData>();
36 36
37 base::string16 keyword = 37 base::string16 keyword =
38 base::UTF8ToUTF16(prefs->GetString(prefs::kDefaultSearchProviderKeyword)); 38 base::UTF8ToUTF16(prefs->GetString(prefs::kDefaultSearchProviderKeyword));
39 std::string search_url = 39 std::string search_url =
40 prefs->GetString(prefs::kDefaultSearchProviderSearchURL); 40 prefs->GetString(prefs::kDefaultSearchProviderSearchURL);
41 if (keyword.empty() || search_url.empty()) 41 if (keyword.empty() || search_url.empty())
42 return scoped_ptr<TemplateURLData>(); 42 return scoped_ptr<TemplateURLData>();
43 43
44 scoped_ptr<TemplateURLData> default_provider_data(new TemplateURLData); 44 scoped_ptr<TemplateURLData> default_provider_data(new TemplateURLData);
45 default_provider_data->short_name = 45 default_provider_data->SetShortName(
46 base::UTF8ToUTF16(prefs->GetString(prefs::kDefaultSearchProviderName)); 46 base::UTF8ToUTF16(prefs->GetString(prefs::kDefaultSearchProviderName)));
47 default_provider_data->SetKeyword(keyword); 47 default_provider_data->SetKeyword(keyword);
48 default_provider_data->SetURL(search_url); 48 default_provider_data->SetURL(search_url);
49 default_provider_data->suggestions_url = 49 default_provider_data->suggestions_url =
50 prefs->GetString(prefs::kDefaultSearchProviderSuggestURL); 50 prefs->GetString(prefs::kDefaultSearchProviderSuggestURL);
51 default_provider_data->instant_url = 51 default_provider_data->instant_url =
52 prefs->GetString(prefs::kDefaultSearchProviderInstantURL); 52 prefs->GetString(prefs::kDefaultSearchProviderInstantURL);
53 default_provider_data->image_url = 53 default_provider_data->image_url =
54 prefs->GetString(prefs::kDefaultSearchProviderImageURL); 54 prefs->GetString(prefs::kDefaultSearchProviderImageURL);
55 default_provider_data->new_tab_url = 55 default_provider_data->new_tab_url =
56 prefs->GetString(prefs::kDefaultSearchProviderNewTabURL); 56 prefs->GetString(prefs::kDefaultSearchProviderNewTabURL);
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 void ConfigureDefaultSearchPrefMigrationToDictionaryValue( 156 void ConfigureDefaultSearchPrefMigrationToDictionaryValue(
157 PrefService* pref_service) { 157 PrefService* pref_service) {
158 if (pref_service->GetInitializationStatus() == 158 if (pref_service->GetInitializationStatus() ==
159 PrefService::INITIALIZATION_STATUS_WAITING) { 159 PrefService::INITIALIZATION_STATUS_WAITING) {
160 pref_service->AddPrefInitObserver( 160 pref_service->AddPrefInitObserver(
161 base::Bind(&OnPrefsInitialized, base::Unretained(pref_service))); 161 base::Bind(&OnPrefsInitialized, base::Unretained(pref_service)));
162 } else { 162 } else {
163 MigrateDefaultSearchPref(pref_service); 163 MigrateDefaultSearchPref(pref_service);
164 } 164 }
165 } 165 }
OLDNEW
« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/search_engines/default_search_pref_migration_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698