chrome/browser/chrome_content_browser_client_unittest.cc - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider_unittest.cc ('k') | chrome/browser/extensions/api/search_engines_private/search_engines_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client_unittest.cc

diff --git a/chrome/browser/chrome_content_browser_client_unittest.cc b/chrome/browser/chrome_content_browser_client_unittest.cc

index 6d37b76d0a17dcbe04e78d94d260ac617890c7fc..6b35cb94ddaa24ed638a134ecdc332b3825819e0 100644

--- a/chrome/browser/chrome_content_browser_client_unittest.cc

+++ b/chrome/browser/chrome_content_browser_client_unittest.cc

@@ -6,6 +6,7 @@

#include "base/command_line.h"

#include "base/metrics/field_trial.h"

+#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -163,6 +164,7 @@ class InstantNTPURLRewriteTest : public BrowserWithTestWindowTest {

ui_test_utils::WaitForTemplateURLServiceToLoad(template_url_service);

TemplateURLData data;

+ data.SetShortName(base::ASCIIToUTF16("foo.com"));

data.SetURL("http://foo.com/url?bar={searchTerms}");

data.new_tab_url = new_tab_page_url.spec();

TemplateURL* template_url = new TemplateURL(data);